-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --with-compat by default #33
Comments
also when building modules, it seems I don't know if all modules are affected or just the one i am building (https://github.com/ruslantalpa/lua-upstream-cache-nginx-module) |
We could add Not sure about the https://github.com/openresty/openresty/blob/master/patches/nginx-1.15.8-dtrace.patch This patch was created before nginx has got dynamic module support. It would be great if you can help dig this up. Pull requests welcome :) Thanks! |
a quick followup for anyone reading this, i was able to build the module using this
this was for and the vars were
it seems it's safe to eliminate |
the dtrace part will probably be hard for me to figure out but the |
about the dtrace, if you can point me in the right direction about that patch (list of files from there that could cause this, just to narrow it down a bit), i could look into it. |
Thanks. It might be our changes in the files under the |
Per discussion in openresty#33 this flag is is needed to be able to easely build aditional dynamic nginx modules
without this flag, building dynamic modules, targeting a specific openresty package release is a pain. One has to use
-V
option to figure out the build arguments used when building the official release and jsut a copy/pasted does not work since paths are not the sameIs this flag missing on purpose?
with this flag one basically needs just
./configure --with-compat --add-dynamic-module=..
The text was updated successfully, but these errors were encountered: