Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Fix wradlib hvplot render #82

Closed
wants to merge 3 commits into from

Conversation

mgrover1
Copy link
Contributor

Closes #81

@kmuehlbauer - For the pages to render properly with myst, I believe the extension needs to be set in the imports section! This adds that in 👍

Copy link

github-actions bot commented Aug 20, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 2f2edb2
✅ Deployment Preview URL: https://openradar.github.io/erad2024/_preview/82

kmuehlbauer
kmuehlbauer previously approved these changes Aug 20, 2024
Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgrover1 Great! Did you run pre-commit, might need an update, though.

@mgrover1
Copy link
Contributor Author

I did not - I can run it!!

@mgrover1
Copy link
Contributor Author

@kmuehlbauer - this now includes the properly linted notebook

@kmuehlbauer
Copy link
Collaborator

@kmuehlbauer
Copy link
Collaborator

@mgrover1 Do you more ideas to tackle this. Not sure where to ask, though. At least in the past this worked well with the older build system in erad2022.

@mgrover1
Copy link
Contributor Author

I do not... I am curious if we should open an issue on the mystmd side...

@kmuehlbauer
Copy link
Collaborator

Yes, probably a good idea to ask. Can you suggest where?

So the tricky part is, that the notebook is currently rendered with nbconvert directly via pytest script ( see https://github.com/openradar/erad2024/blob/main/conftest.py).

@mgrover1
Copy link
Contributor Author

New issue opened @kmuehlbauer 😄 jupyter-book/mystmd#1488

@mgrover1
Copy link
Contributor Author

Closing this since I could not resolve this issue

@mgrover1 mgrover1 closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bokeh/hvplot DynamicMap not rendered in output
2 participants