Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When did incremental became stable? #648

Open
vicb opened this issue Nov 25, 2024 · 1 comment
Open

When did incremental became stable? #648

vicb opened this issue Nov 25, 2024 · 1 comment
Labels
question Further information is requested

Comments

@vicb
Copy link
Contributor

vicb commented Nov 25, 2024

@petebacondarwin noted this code in https://github.com/opennextjs/opennextjs-aws/blob/2202f36ce0f87357b249bd127cdd5e84d6deffd3/packages/open-next/src/build/createServerBundle.ts

  const isAfter141 =
    buildHelper.compareSemver(options.nextVersion, "14.0.4") >= 0;
// ...

    openNextReplacementPlugin({
      name: `utilOverride ${name}`,
      target: /core(\/|\\)util\.js/g,
      deletes: [
        ...(isAfter141
          ? ["experimentalIncrementalCacheHandler"]
          : ["stableIncrementalCache"]),
      ],
    }),

Which of 14.0.4 or 14.1 is the correct version?

@conico974
Copy link
Contributor

Good catch, it's 14.1, even though technically it was released on a canary branch (i.e. v14.0.5-canary.65)

BTW you guys should probably throw on version of next < 13.4.13 (or at least show a big warning).
Before that version, we use the built-in middleware/routing in Next (which will fail on cloudflare)

@vicb vicb added the question Further information is requested label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants