Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score update problem #64

Open
goncalogato opened this issue Dec 17, 2024 · 13 comments
Open

Score update problem #64

goncalogato opened this issue Dec 17, 2024 · 13 comments

Comments

@goncalogato
Copy link

Hello,

When you change a score object by going inside and edit, it does not display the change when you close it. It does update when you click m two times (thus hiding and showing the content again). This can slow down visualisation inside OM.

thanks
g

@karimhaddad
Copy link
Member

Dear G

Sorry but i am not sure to understand you well here:

  1. which OS are you using
  2. Is the patch 171224 installed?

When you say going inside and edit you mean changing notes? and then close it?
Can you be more precise?

Thank you

Best
K

@karimhaddad
Copy link
Member

Dear Goncalo,

Ok i could see the problem. It is macosx related. I have fixed it and will issue a new patch tomorrow.
But if you are in a hurry, you can copy paste this code at the end of the last patch i've put onlune:

(defmethod move-selection ((self scorePanel) dir)

  (loop for item in (selection? self) do
          (score-move-a item self (cond
                                   (#+(or cocoa win32)(om-option-key-p)
                                    #+linux(om-option-key-p) 
                                    (if (= dir 0) 700 -700))
                                   ((om-shift-key-p) (if (= dir 0) 1200 -1200))
                                   (t (let ((factor (round (approx-factor (get-current-scale (staff-tone self))))))
                                        (if (= dir 0) factor
                                          (* -1 factor)))))))
  #+(or linux win32)(update-panel self t)
  #+macosx(unless (in-page-mode? self)
            (update-alt-panel self)
            )
  #+macosx(update-slot-edit self)
  (om-invalidate-view self)
    #+macosx(progn
            (change-edit-mode (car (frames (associated-box (object (editor self))))))
            (change-edit-mode (car (frames (associated-box (object (editor self)))))))
    )

Best
K

@goncalogato
Copy link
Author

goncalogato commented Dec 18, 2024

Thanks so much. Yes, using MacOS here.

@karimhaddad
Copy link
Member

Now the patch is available.

Best
K

@goncalogato
Copy link
Author

goncalogato commented Dec 18, 2024

Hello. It seems that, with the new patch, score objects are not editable by selecting the note and using the arrows: this generates a popup window with an error message.

Also, it seems that CHORD-SEQ-ANALYSIS is having trouble outputting an SDIFFILE. There is this message in the Listener: "Removing files:" and then the path to the newly-generated file (in ~/Library tempchords, and workspace out-files/chordseqs.sdif) is listed... This is probably why it can't pass the sdif file to the SDIFFILE object.

@goncalogato
Copy link
Author

goncalogato commented Dec 18, 2024

Arrow issue seems to happen only with the NOTE object.

@karimhaddad karimhaddad reopened this Dec 18, 2024
@karimhaddad
Copy link
Member

Dear Goncalogato,

Please can you be more specific here?

  1. Can you provide the popup window of the error message, and confirm that this happens ONLY in the NOTE object?
    It is not clear to me.

  2. The SDIFFILE and the chord-seq-analysis is a completely different issue. Can you open a new ticket for that, and please try to be more specific. If the analysis fails, it could be either, you are using an old version of the OM-pm2 library, or an old version of pm2 binary, etc...

Best
K

@goncalogato
Copy link
Author

goncalogato commented Dec 18, 2024

Yes, sure. Here is the error I get while editing NOTE with arrows:

image

The problem does not happen with CHORD, CHORD-SEQ, VOICE and POLY (tried with the default one voice).

PS: I will open another ticket for the pm2.

Thanks,
G

@karimhaddad
Copy link
Member

Dear G,

Thank you again. Your feedback is really appreciated.
You just found a bug which is fixed (cf. the new patch available in the release section).
And please feel free to report any other issue you may find.

Best Regards
Karim

@goncalogato
Copy link
Author

Dear K,

With the latest patch_191224.lisp I still get the error message in NOTE, while using the arrows inside. Thank you

@karimhaddad karimhaddad reopened this Dec 19, 2024
@karimhaddad
Copy link
Member

Yes you're right.
and sorry didn't understand that it was the NOTE editor. Got mixed up with the internal editor of chord-seq.
Will issue a new patch.

Best
K

@karimhaddad
Copy link
Member

Dear G

Can you now replace the pathc by the new one?
I think it is fixed.

Best
K

@goncalogato
Copy link
Author

This is now working correctly. Thank you so much. Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants