[REVIEW]: ESAT: Environmental Source Apportionment Toolkit Python package

[editorialbot]

Submitting author: @deronsmith (Deron Smith)
Repository: https://github.com/quanted/esat
Branch with paper.md (empty if default branch):
Version: 2024.0.2
Editor: @mengqi-z
Reviewers: @gutabeshu, @ifoxfoot, @niravlekinwala
Archive: Pending

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8d2f7f5cfcb1f2ac82acd55d5855c5ac"><img src="https://joss.theoj.org/papers/8d2f7f5cfcb1f2ac82acd55d5855c5ac/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8d2f7f5cfcb1f2ac82acd55d5855c5ac/status.svg)](https://joss.theoj.org/papers/8d2f7f5cfcb1f2ac82acd55d5855c5ac)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@gutabeshu & @ifoxfoot & @niravlekinwala, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mengqi-z know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @ifoxfoot

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=6.52 s (34.1 files/s, 582999.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            19           2778             78          11232
Jupyter Notebook                52              0        3753053           8504
Python                          36           1252           2138           6687
SVG                              4              0              1           2691
PO File                         45           1007              0           2284
JavaScript                      20            231            297           1894
CSS                             12            424             93           1805
CSV                              4              0              0           1454
Rust                             1             71              9            537
Markdown                         2             68              0            241
reStructuredText                18            159            260            218
YAML                             4             10              5            134
TeX                              1             11              0            116
TOML                             2             12              2             67
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           222           6035        3755944          37899
-------------------------------------------------------------------------------

Commit count by author:

   155	Deron Smith
    19	mikecyterski

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 995

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: Apache License 2.0 (Valid open source OSI approved license)

[editorialbot]

⚠️ An error happened when generating the pdf.

[mengqi-z]

@editorialbot generate pdf

[editorialbot]

⚠️ An error happened when generating the pdf.

[mengqi-z]

👋🏼 @deronsmith, @gutabeshu, @ifoxfoot, @niravlekinwala - This is the review thread for the paper. All of our communications will happen here from now on.

As a reviewer, the first step is to create a checklist for your review by entering

@editorialbot generate my checklist

as the top of a new comment in this thread.

These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/7316 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time.

Please feel free to ping me (@mengqi-z) if you have any questions/concerns.

[ifoxfoot]

Review checklist for @ifoxfoot

Conflict of interest

• I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

• I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• Repository: Is the source code for this software available at the https://github.com/quanted/esat?
• License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
• Contribution and authorship: Has the submitting author (@deronsmith) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
• Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
• Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
• Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
• Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
• A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
• State of the field: Do the authors describe how this software compares to other commonly-used packages?
• Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
• References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

[ifoxfoot]

@editorialbot generate pdf

[editorialbot]

⚠️ An error happened when generating the pdf.

[mengqi-z]

@openjournals/dev - The PDF is not generating correctly. Could you please help me looking into the issue? Thank you!

@gutabeshu, @ifoxfoot, @niravlekinwala @deronsmith - In the meantime, you can access the most recent PDF from the Pre-Review stage here: #7215 (comment). Apologies for the inconvenience!

[arfon]

@editorialbot generate pdf

[editorialbot]

⚠️ An error happened when generating the pdf.

[arfon]

@mengqi-z – the issue here is that there are two paper.md files in the repository and there must only be one. @deronsmith – could you clean this up please by removing or renaming the one that is not the JOSS paper?

[mengqi-z]

@arfon - Ah, I see! It turns out there is a paper.md file located under esat/docs/html/_sources/paper/. Thanks for spotting the issue!