Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: flory: A Python package for finding coexisting phases in multicomponent mixtures #7304

Open
editorialbot opened this issue Sep 30, 2024 · 11 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 30, 2024

Submitting author: @qiangyicheng (Yicheng Qiang)
Repository: https://github.com/qiangyicheng/flory
Branch with paper.md (empty if default branch):
Version: 0.2.0
Editor: @srmnitc
Reviewers: Pending
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e95e55e086acf4c019e8f3854e048dac"><img src="https://joss.theoj.org/papers/e95e55e086acf4c019e8f3854e048dac/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e95e55e086acf4c019e8f3854e048dac/status.svg)](https://joss.theoj.org/papers/e95e55e086acf4c019e8f3854e048dac)

Author instructions

Thanks for submitting your paper to JOSS @qiangyicheng. Currently, there isn't a JOSS editor assigned to your paper.

@qiangyicheng if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Sep 30, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/S0364-5916(02)00037-8 is OK
- 10.1038/s41578-019-0121-4 is OK
- 10.1021/acs.jctc.3c00198 is OK
- 10.1145/2833157.2833162 is OK
- 10.1039/C8SM02045K is OK
- 10.1039/C3SM51893K is OK
- 10.5334/jors.140 is OK
- 10.1007/978-94-011-0065-6_11 is OK
- 10.1088/0953-8984/10/37/002 is OK
- 10.1073/pnas.2108551118 is OK
- 10.1016/j.commatsci.2015.01.029 is OK
- 10.1073/pnas.2201250119 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Computational Thermodynamics: The Calphad Method
- No DOI given, and none found for title: Scaling of Phase Count in Multicomponent Liquids
- No DOI given, and none found for title: SciPy 1.0: Fundamental Algorithms for Scientific C...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.06 s (1354.6 files/s, 141430.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          53           1126           2175           2790
TeX                              3             45              0            396
Markdown                         3             74              0            241
reStructuredText                 7            130            338            230
YAML                             5             25             22            154
TOML                             1             14              0             85
DOS Batch                        1              8              1             26
make                             2             11              9             23
CSS                              1              3              0              9
-------------------------------------------------------------------------------
SUM:                            76           1436           2545           3954
-------------------------------------------------------------------------------

Commit count by author:

   143	Yicheng Qiang
    47	Yicheng Qiang (强 宜澄)
    30	David Zwicker

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1039

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@kyleniemeyer
Copy link

@editorialbot invite @srmnitc as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

AmpTorch: A Python package for scalable fingerprint-based neural network training on multi-element systems with integrated uncertainty quantification
Submitting author: @ajmedford
Handling editor: @dhhagan (Retired)
Reviewers: @ml-evs, @ianfhunter
Similarity score: 0.7276

OpenTerrace: A fast, flexible and extendable Python framework for thermal energy storage packed bed simulations
Submitting author: @jakobhaervig
Handling editor: @AdamRJensen (Active)
Reviewers: @baperry2, @AdamRJensen
Similarity score: 0.7254

SurfinPy 2.0: A Phase Diagram Generator for Surfaces and Bulk Phases
Submitting author: @jstse
Handling editor: @lucydot (Active)
Reviewers: @awvwgk, @dandavies99
Similarity score: 0.7224

Bluebonnet: Scaling solutions for production analysis from unconventional oil and gas wells
Submitting author: @frank1010111
Handling editor: @matthewfeickert (Active)
Reviewers: @AnantHariharan1996, @RyanSwindeman
Similarity score: 0.7196

physical_validation: A Python package to assess the physical validity of molecular simulation results
Submitting author: @ptmerz
Handling editor: @rkurchin (Active)
Reviewers: @tonigi, @geraldjwang, @zadehsey
Similarity score: 0.7168

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@srmnitc
Copy link
Member

srmnitc commented Oct 1, 2024

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @srmnitc is now the editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants