Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive DOI not validated #103

Open
sneakers-the-rat opened this issue Mar 22, 2024 · 1 comment
Open

Archive DOI not validated #103

sneakers-the-rat opened this issue Mar 22, 2024 · 1 comment

Comments

@sneakers-the-rat
Copy link
Contributor

Re:

@sdruskat found two papers which had incorrect archive DOIs (nice catch!),

The responder is here: https://github.com/openjournals/buffy/blob/joss/app/responders/openjournals/set_archive_responder.rb

and there is already a valid_doi_value method - it seems like we should probably at least check that the link doesn't 404, right? Would additional validation be useful or overengineering? Since we allow any archive to be used, and the archive might also not share the title with with the reviewed work, it seems like it might be hard to validate that "this archive link is for sure the right one"

some ideas:

  • query eg. crossref for the archive metadata, prompt with a warning when the title is >threshold different than the submitted work title
  • add an item to post-review editorial/author checklist that is "ensure that the archive link is the right thing"

thoughts? i'd be happy to PR whatever we decide here :)

@sdruskat
Copy link

Thanks for pinging me, @sneakers-the-rat.

I agree that doing some checking of DOIs would be great.

Point in case, I just found that the software_archive for https://joss.theoj.org/papers/10.21105/joss.00041 leads to a paper about a species of bee 🐝 from 1910, written in French 😆. This is as far as it gets from a software archive I believe 😉. (The correct DOI would have been https://doi.org/10.5281/zenodo.61965).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants