Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: online state cache #2393

Open
wants to merge 148 commits into
base: main
Choose a base branch
from
Open

feat: online state cache #2393

wants to merge 148 commits into from

Conversation

withchao
Copy link
Collaborator

@withchao withchao commented Jul 4, 2024

🅰 Please add the issue ID after "Fixes #"

Fixes #2392

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 4, 2024
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

if err != nil {
return nil, errs.Wrap(err)
}
platformIDs = append(platformIDs, int32(val))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of an integer with architecture-dependent bit size from
strconv.Atoi
to a lower bit size type int32 without an upper bound check.
pkg/rpccache/online.go Fixed Show fixed Hide fixed
if err != nil {
return "", nil, err
}
platformIDs[i] = int32(platformID)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types High

Incorrect conversion of an integer with architecture-dependent bit size from
strconv.Atoi
to a lower bit size type int32 without an upper bound check.
skiffer-git
skiffer-git previously approved these changes Jul 8, 2024
skiffer-git
skiffer-git previously approved these changes Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: online state cache
5 participants