Plan for new App Release #756
Comments
|
@timbms @weakfl Thoughts on the plan? Specifically to get started i think we need to agree on a 1) branching strategy (create From there i think we can start assigning tasks, i can handle the FCM changes and can update the legacy app with new logos, name, remove watchkit, and add the popup to start. I'm kinda partial to merging |
|
Here's an example of another app that renamed theirs "legacy", so at least there is precedence for this. |
The actual development was on 'develop'. Therefore we should branch 'openhab-legacy' from develop. 'main' was not used recently for development. I don't know how much effort it will be to bring 'develop' to 'main'. |
|
I started to merge develop into main, which was fine, but since we don't really use it, i just renamed to |
|
openhab legacy branch from develop |
|
Does anyone have any experience with the privacy file @weakfl mentioned? I'm reading about it, and besides making sure our 3rd party libraries are updated and have this file, i'm not sure that we actually access or collect anything that needs to be declared? We do access EDIT: see #757 |
|
Moving right along. Now that the privacy policy and messaging changes are in, i think its time to start working on the two different apps and ids. For our new build, shall we go with Thoughts? |
|
Just giving my two cents to this discussion without being an iOS app developer:
Would something like |
|
Thanks @florian-h05! There's an old (ish) saying in computer science:
Naming things is hard ;-) Using darwin is an interesting thought, although i wonder if thats kinda implied just by being in the apple app store. I was looking around for some inspiration, Sonos uses I guess in the end its not super important, i just know once we publish its set in stone this time. |
|
Throwing my hat in the ring with In the end it wont matter much, no one ever sees the bundle id anyway. SKU is harder imho 😂 |
|
How about just |
|
So openHAB Legacy does not fit well as a bundle display name, IOS is removing the space to try and get it to fit: 
What about use something like 
|
|
@timbms and @weakfl looks like there are a few pull requests that add new features, or require the new SDK versions. How shall we handle those? I'm probably going to run out of time this weekend to do much else, but i will try and get some dev time in later in the week. My next steps are to work on the legacy app and add an upgrade UI to it as well as change the logo slightly to differentiate from the main app. |
|
Yes I wrote some of them. I wished we could at least upgrade to SwiftUI watch app |
I'm not super familiar with SwiftUI, is there a reason we can't ? Also i was looking at IOS SDK compatibility and it seems like IOS 15 is really the floor, IOS 14 does not seem to be a max version for any device, see https://iosref.com/ios . Should we set the min SDK version to 15 ? |
|
Apple's recommendation is current and previous version, so that would be iOS 16. Would be really beneficial for SwiftUI as well. |
|
So i think IOS 16 sounds like a good base version to me , i guess this will be one advantage of having two apps, we can keep the current target with the legacy app for those with older devices. |
|
iOS 16 would be great. We just need to make sure to also adapt swiftlint/swiftformat configs (and swift-version). That will help to catch all sorts of obsolete availability checks and update swift syntax to the latest version. |
|
So i was thinking about something like this to message users to upgrade to the new app. Needs some UI formatting and cleanup, but you get the idea. I was thinking this would display when the app is launched, and is also available in the settings menu. The user has the option of not being reminded before dismissing. 
|
|
Just to add my 2 cents. |
|
sure. Old devices can stay on legacy app. iOS 16 runs on iPhone 8 and iPadOS 16 runs on iPad 5th generation from 2017. |
|
iOS 16/17 covers 96% of users. This will further increase with the release of iOS 18. |
Ok, absolutely forgot this option ;-) |
|
Unfortunately I cannot add much to this discussion, app development is not my expertise. But if I can support or move this forward in any way, let me know. I would really like to have this app updated with the slider fix 👍 |
|
@weakfl @timbms , i am thinking through what needs to be done to prepare for publishing the 2 apps. Would appreciate some help here on what needs to be changed. ** App Store Connect Tasks ** (Manually configuring on https://appstoreconnect.apple.com)
** Fastlane Changes **
** Github Actions **
Let me know what you think , I'm hoping to update the legacy images this week. |
|
So i have changed the app on apple connect to |
|
@weakfl i'm having a wee bit of trouble with fastlane. First is just getting it running again with github actions for testflight builds. Second, I am manually submitting builds until we can get it automated, but i was still hoping to use fastlane locally to generate screenshots for the app store. Thats still not working for me as much as i have tried. If you could help me fix that so i can at least run it locally, would be a big help. |
|
Its still working for me, what are you using for the media attachment URL ? |
|
also you should be on 3.0.3(7), yes? |
|
I am using |
|
Ah, your right, not sure how i missed that, give me a few and i'll push a new release, probably a small thing from refactoring the HTTP client. |
|
Actually i take that back, the image item i quickly tested with had a null state. Is there anything different about your setup, i think you are using client based certs ? |
|
Yeah, I am using client cert auth, but if I disable wifi on my phone, openHAB cloud should be used and it also doesn't work there. |
|
So i can confirm the the client certs are not working (they were at one point) with the new http client code, so thats something. I'll play around more with that tonight and double check the cloud connection logic. |
|
@florian-h05 i have a fix, was banging my head a bit until i realized the notification extension was not using the same keychain as the main app, keychain sharing has to be explicitly enabled through entitlements. Working now, i'll merge shortly and a testflight build will follow. |
|
@florian-h05 let me know if the latest testflight works for you. |
|
Just tested it - works again. Thanks! |
|
I've installed the latest TestFlight version and everything works fine! Thanks for the great work!!! Just a question, The icons on the watch are not shown. Because the fix for #748 isn't included in the current TestFlight version? |
Why not ?
|
|
But it is shown under installed Apps? |
|
Are we ready to submit the new release for review? Or do we need some more work before we can? |
|
What’s the status here? |
@digitaldan, there are a few typos: "experince", "recomend", "IOS (iOS)". |
I just need to find time to start the process. Once we submit, its going to be a lot of back and forth with Apple review team, as i'm expecting a lot of explaining about the two apps, and probably some changes we will need to make to logos, names, etc...
Are you going off the prototype screenshot, or the actual message in the resource files, which is different the what i posted above and is also translated into multiple languages? |
|
I checked the screenshot. I couldn't find the actual resource. |
|
Just an FYI i have submitted both apps for review. Our legacy/v1 app was approved shockingly fast. Its ready to release when we are ready. The new v3.0 app is in its second round of review, they apparently did not like having the string "iOS App" in the app description as in: "The Official openHAB iOS App" , apparently that's against the rules ??? Uhg 🤷 . When our new app is ready, i will release the V1/Legacy app then so have both versions in the store at the same time. Once thats complete, i will update a string on our cloud service which will trigger the V1 app to notify users of the updated experience. 🤞 |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Just an update, we were rejected again due to violating "Spam" polices, as I expected they don't like having 2 similar apps in the store. I have submitted our reason for exception to this policy, also pointing out other vendors like Sonos ( https://apps.apple.com/us/developer/sonos-inc/id293523034 ) who have similar V1 and V2 apps. I'll keep people up to date here as our submission progresses. |
|
IMO this is embarrassing from Apple’s side: First they “loose” the Apple Watch app ID and thereby force us to release a new app and then they make it difficult to release a new app … DX could be clearly better. Thanks for the update though! |
|
I'm shocked, but they accepted our new app and its ready to publish! I was 99% sure we were going to have a few more rounds of reviews, so that good news. I'll release it shortly, verify its available, then release the v1 app and do the same. Once thats done, i'll updated the current app version on the cloud service, which will trigger the V1 app to display the update message. I had originally thought Apple might have made us publish the legacy app first, hence wanting to delay the update message until the new one was published, but in hindsight, that was not necessary. |
|
Both apps are out. I have submitted another version of the new app so i can change the name from "openHAB V2" to "openHAB". Apple would not allow the name change until our legacy app published and released the "openHAB" name (its now "openHAB V1") . |
|
I am very, very happy to be able to close this issue. Both apps are released, with proper names, logos, etc.... Thanks everyone for helping out. 
|
|
Any idea if there are still plans to add svg support for the icons on an Apple Watch? Or should I open a new issue for this? |
Please create a new issue, as this is not specific related to this thread |
Here's the latest news from Apple. I spoke with a developer support rep on Friday after months of back and forth emails. Basically, our watch ID has been claimed by another developer account, and they won't tell us who that is or reclaim it for us.
Because of this, we can no longer push our app with watchkit support any longer as that ID can not be changed once published in the app store. This seems to be confusing to Apple as well as we have gone through several back and forth with tickets escalated to their dev team.
Our case is still open and i sent a fresh batch of error logs to them after trying a few changes they recommended, but i have little to no confidence now that Apple is going to be able to help.
My suggestion is that we publish this as a new app and new app ID into the app store. I would also like to then push an update to our existing app that will direct users to download the new app, maybe a simple popup that gets triggered at launch stating the issue.
see #746 for more history on this
Todo Items
openhab-legacyas the branch name)org.openhab.mobile.iosor equivalent ( lets discuss the best name to use here)1416 as min SDK levelopenHAB legacy changes
openHAB V1app in codeDeployment Todo
We need to work out timing. Ideally we would get the new app approved and published before renaming the current app and pushing an update to it. But we also don't want to be rejected by submitting an app first with the same name and icon (although i have seen this with other companies like solaredge who had two apps for a while)
The text was updated successfully, but these errors were encountered: