-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown options are rendered above the title sticky header when scrolling #6026
Comments
Hi i would like to work on this issue |
Hi @packirisamykaran! Sure, thanks for the initiative! Before you start work, could you sign our Contributor License Agreement? Thank you! |
Alright, I have signed. |
Hi @packirisamykaran, sorry, could you fill in the form again here: https://go.gov.sg/ogp-cla-2023? We didn't receive your response the previous time. After which, you can start on your development if you haven't already! 👍 |
Alright no worries, I have submitted it again. Let me know if you have received it |
Yup, got it! Thank you! |
Great thanks |
Hello @LinHuiqing, I am new to contributing to open-source projects and I am unable to log in due to not being on the whitelist. can I only locate and resolve the issue by browsing through the repository? |
Hey @packirisamykaran! When developing on your local environment, you can login with any hypothetical email ending with "gov.sg". The OTP will printed through to terminal on the backend, or you can use the MailDev server to receive incoming mails at https://localhost:1080. |
Ok it works. thank you |
Hi @LinHuiqing, I would like to work on this issue! I have already signed the CLA. |
Hey @LeonardYam, sorry for the late reply. Sure, go ahead, thanks! |
Hi @LinHuiqing, I've discovered the issue - Recording.movAn alternative would be to keep the portal but pass a suitable DOM node to append the dropdown options. Let me know which approach is preferred here :) |
Hi @LeonardYam, sorry for the delayed replies as I'm travelling 😅 I think the former approach will work, thanks! Do open a PR with the fix and we'll review accordingly. Thank you! |
Updating this issue. From UX point of view, the intended interaction should be to close the popover when scrolled out of view (including under the header). This is to ensure that users are not interacting with elements that are outside of their viewport |
Describe the bug
Dropdown options are rendered above the title sticky header when scrolling.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Dropdown options should go under the title sticky header when they overlap during scrolling.Close popover when combobox is scrolled out of view
Screenshots
Screen.Recording.2023-03-31.at.1.15.56.PM.mov
The text was updated successfully, but these errors were encountered: