Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python interface for functionality #47

Open
felix-schott opened this issue Oct 13, 2023 · 0 comments
Open

Python interface for functionality #47

felix-schott opened this issue Oct 13, 2023 · 0 comments

Comments

@felix-schott
Copy link
Collaborator

Description

I think a proper python interface would be nice to have, in addition to the CLI.

The following things should probably be changed, just gathering my thoughts here:

  • find a more descriptive name for function download()
  • use python logger instead of click.echo() - this removes the need for a bunch of flags for the download function like silent, as this is all handled by the built-in python logger. Using the python logger allows users to register their own handlers more easily. The CLI can simply translate flags into logger settings.
  • ...

I might make a PR when I have time, just wondering if you have any thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant