Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #36

Open
cholmes opened this issue Oct 9, 2023 · 2 comments
Open

Add tests #36

cholmes opened this issue Oct 9, 2023 · 2 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@cholmes
Copy link
Collaborator

cholmes commented Oct 9, 2023

We have a nice CI system that checks multiple operating systems to be sure that all still works. But there's one big problem - there's no tests that it runs. It's been a one man project, but if the community grows it's essential to be able to automatically check if changes broke something unexpected (also good even when it is a one man project).

ChatGPT can likely help in the creation of tests. Would be good to have unit tests, and also some more integration tests that use the source.coop files to ensure it's all working.

@cholmes cholmes added this to the 0.10.0 milestone Oct 9, 2023
@cholmes cholmes added the help wanted Extra attention is needed label Oct 9, 2023
@felix-schott
Copy link
Collaborator

Hi Chris,
Do you mind if the tests use pytest instead of the unittest module? If so, I'll add some tests in the next couple days (I'm more comfortable with pytest). Note that it'll be easier to unit test things if the download function is decoupled from the CLI functionality. Also nicer to have a proper Python interface as this allows for more complex scripting applications. So the changes might involve some refactoring. I'm having a go locally and will push a PR in the next few days if you're fine with that!
Cheers
Felix

@cholmes
Copy link
Collaborator Author

cholmes commented Oct 10, 2023

Hey @felix-schott - that'd be awesome! I am totally happy with pytest if you're up to contribute. To be honest I've never written tests in Python - this is my first python coding project, so I'm more than happy for any guidance. And once the tests framework is in place I'll be sure to make use of it. And refactoring is definitely completely welcome as well, and it would be great to have a nice python interface.

This was referenced Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants