Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get-buildings more robust #13

Open
cholmes opened this issue Aug 31, 2023 · 2 comments
Open

Make get-buildings more robust #13

cholmes opened this issue Aug 31, 2023 · 2 comments
Labels
get_buildings Issues related to the get_buildings operations help wanted Extra attention is needed
Milestone

Comments

@cholmes
Copy link
Collaborator

cholmes commented Aug 31, 2023

The get-buildings command seems to work decently well, but it does very little in the way of catching all the things a user might input things wrong. It'd be good to test out common ways that it wouldn't work right and give better warnings, etc.

It also appears to hang if you don't supply the file, I think since it's expecting stdin. I definitely want to keep the ability to do stdin, but ideally can warn users. In planet CLI we had '-' mean 'read from stdin' so that could be a good pattern to follow.

@cholmes cholmes added this to the 0.8.0 milestone Aug 31, 2023
@cholmes
Copy link
Collaborator Author

cholmes commented Oct 9, 2023

One thing to test in particular is GeoJSON input that is not valid, is a point or line, or has more than one polygon. We should get to some nice default behaviors, and warn users what's happening (like auto-buffer points or lines, automatically select the first polygon (and/or give an option to union all polygons).

@cholmes cholmes modified the milestones: 0.8.0, 0.10.0 Oct 9, 2023
@cholmes cholmes added get_buildings Issues related to the get_buildings operations help wanted Extra attention is needed labels Oct 9, 2023
@felix-schott
Copy link
Collaborator

Hi Chris,
Thanks for developing this tool. I'm happy to work on GeoJSON validation! Expect a PR in the next couple days :)
Felix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
get_buildings Issues related to the get_buildings operations help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants