Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product list: Don't reload whole table when saving or discarding changes #510

Open
mariocarabotta opened this issue Dec 28, 2023 · 4 comments

Comments

@mariocarabotta
Copy link

No description provided.

@RachL
Copy link
Contributor

RachL commented Apr 8, 2024

@mariocarabotta is this one a duplicate of openfoodfoundation/openfoodnetwork#11987 ?

@mariocarabotta
Copy link
Author

mmm no not really. While talking with David, we identified they are different flows and touch different parts of the codebase, so we decided to split them into separate issues

@dacook
Copy link
Member

dacook commented Jun 12, 2024

I haven't given this one much thought, but given our current stack, it probably requires more custom javascript. I think we can upgrade BulkFormController to do this, probably with Turbo Streams.
But it's adding complexity and moving back towards an SPA, so I would want to discuss with devs before going down that path.

First it would be good to discuss the requirements from a user point of view. We might be able to solve it by tweaking performance and change the way the table is refreshed/morphed.

@RachL
Copy link
Contributor

RachL commented Jun 12, 2024

Then moving this one to wishlist, I don't think this is a priority 👍 Thanks!

@RachL RachL transferred this issue from openfoodfoundation/openfoodnetwork Jun 12, 2024
@RachL RachL changed the title Don't reload whole table when saving or discarding changes Product list: Don't reload whole table when saving or discarding changes Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Candidates
Development

No branches or pull requests

3 participants