[Orders Page] - Fix Pagination not working

[chahmedejaz]

What? Why?

• Closes [Orders Page] - Pagination is not working #13002
• searchController is also being used on the Orders Page along with Products
• productForm is not accessible on the orders page
• Hence the code breaks on the Orders page when controller action tries to do the scrollIntoView on the productForm
• This PR puts the check in the controller to do the scrollIntoView only if the productForm is available

What should we test?

• As mentioned in the issue
• Also, Re-validate Scroll to top when using pagination #12962

Release notes

Changelog Category (reviewers may add a label for the release notes):

• User facing changes
• API changes (V0, V1, DFC or Webhook)
• Technical changes only
• Feature toggled

[filipefurtad0]

Thanks so much @chahmedejaz ,

I did an early test on this one, prior to code review. Your PR fixes the issue 💪

Before this PR, clicking on the index 2, on the orders page triggers a console error and does not display the following set of orders:

After this PR, it is possible to use page index navigation, before the introduced regression:

Re-tested #12962: navigating between different pagination indexes scrolls up the page.

Also had a look on the users page, BOM, and customers page, all using pagination as well. These seem to work as before.

This looks good to go, from a testing perspective 🟢

[dacook]

Thanks for fixing this so quickly Ahmed!

It would be best not to have a reference to a specific page element in this generic controller, but this is worth doing for the quick fix.

[mkllnk]

Great! 🌟