Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] Activate admin_style_v3 for dev, test and new servers #12627

Closed
5 of 6 tasks
dacook opened this issue Jun 30, 2024 · 6 comments · Fixed by #12668
Closed
5 of 6 tasks

[BUU] Activate admin_style_v3 for dev, test and new servers #12627

dacook opened this issue Jun 30, 2024 · 6 comments · Fixed by #12668
Assignees

Comments

@dacook
Copy link
Member

dacook commented Jun 30, 2024

When the new Backoffice UI Uplift design (admin_style_v3) is the primary design, we need ensure we are using it while developing new changes:

  • dev environments
  • tests (local and CI)
  • staging (these can be managed manually for now)
  • new servers

Steps:

  1. Prepare tests
  • Make admin_style_v3 active by default
    • This will enable for dev, test and new servers (any environment that doesn't already have a saved setting for admin_style_v3)
    • So we can remove the Flipper.enable in base_spec_helper
@dacook dacook converted this from a draft issue Jun 30, 2024
@dacook
Copy link
Member Author

dacook commented Jul 1, 2024

Once #11645 is complete all tests are updated, we should be able to simply make admin_style_v3 ACTIVE_BY_DEFAULT in feature_toggle.rb

@dacook dacook moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Jul 2, 2024
@dacook dacook assigned dacook and unassigned dacook Jul 2, 2024
@dacook dacook moved this from In Progress ⚙ to Dev ready 👋 in OFN Delivery board Jul 2, 2024
@dacook dacook self-assigned this Jul 9, 2024
@dacook dacook moved this from Dev ready 👋 to In Progress ⚙ in OFN Delivery board Jul 9, 2024
@filipefurtad0 filipefurtad0 self-assigned this Jul 9, 2024
@filipefurtad0
Copy link
Contributor

As per delivery circle, I've assigned myself to this issue @dacook .

@dacook
Copy link
Member Author

dacook commented Jul 10, 2024

https://community.openfoodnetwork.org/t/backoffice-ui-product-list-uplift-rollout/2921/33

On July 16th we will release the new admin by default to all super admin and make this the default environment for dev and testers.

This won't all be included in the release next Tuesday 16th, but hopefully we will have it merged in master.

@RachL
Copy link
Contributor

RachL commented Jul 11, 2024

Yes I was getting a bit too optimistic sorry :)

@dacook
Copy link
Member Author

dacook commented Jul 16, 2024

[ ] Make admin_style_v3 active by default

@filipefurtad0 I tested this out on my dev environment to see how it works.

  1. Delete existing feature toggle for admin_style_v3 (Actually I deleted all just for fun)
    Screenshot 2024-07-16 at 10 50 15 am
  2. Copy (not move) admin_style_v3 from CURRENT_FEATURES to ACTIVE_BY_DEFAULT in https://github.com/openfoodfoundation/openfoodnetwork/blob/master/lib/open_food_network/feature_toggle.rb
  3. Restart server. The feature is present and enabled: Screenshot 2024-07-16 at 10 53 25 am
  4. Disabled or partially enable the feature (similar to current prod servers): Screenshot 2024-07-16 at 10 54 34 am
  5. Restart the server. No change was made to the feature toggles.

@filipefurtad0
Copy link
Contributor

I tested this out on my dev environment to see how it works.

Ok, I see. So, if:

  • the feature does not exist, it will create and enable it
  • the feature exists, it does nothing

I've staged the current PR to have a quick test on the current behavior, and added some testing notes on this regard - (it's looking good!)

@github-project-automation github-project-automation bot moved this from In Progress ⚙ to Done in OFN Delivery board Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants