Release v4.4.24

[mkllnk]

1. Preparation on Thursday

• Merge pull requests in the Ready To Go column
• Include translations: script/release/update_locales
• Increment version number: git push upstream HEAD:refs/tags/vX.Y.Z
  • Major: if server changes are required (eg. provision with ofn-install)
  • Minor: larger change that is irreversible (eg. migration deleting data)
  • Patch: all others. Shortcut: script/release/tag
• Draft new release. Look at previous releases for inspiration.
  • Select new release tag
  • Generate release notes and check to ensure all items are arranged in the right category.
• Notify #instance-managers of user-facing 👀, API ⚠️ and experimental 🚧 changes.

2. Testing

• Move this issue to Test Ready.
• Notify @testers in #testing.
• Test build: Deploy to Staging with release tag.

3. Finish on Tuesday

• Publish and notify #global-community (this is automatically posted with a plugin)
• Deploy the new release to all managed instances.
  Command line instructions

  cd ofn-install
  git pull
  ansible-playbook --limit all_prod --extra-vars "git_version=vX.Y.Z" playbooks/deploy.yml
  

• Notify #instance-managers:

  @instance_managers The new release has been deployed.

• Nudge next release manager

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

[filipefurtad0]

Hi @mkllnk ,

I've found no regressions, the release is good to go. Notes here (nothing changed):
https://docs.google.com/document/d/1AAKC6bu55-q1wv__uiMvwiNbZ20bRM7AGtXkZZCqoUk/edit

Two minor issues (not herein introduced):

• Noticed some console errors which seem to be introduced by Stimulus, on the bulk edit product page. I don't think these are concerning, but I'm not sure; The first console error points to polyfills on IE11 (I think no action needed). The second error seems to relate to pagination though, although I found it to work correctly:

• Noticed an unclear message when checking out with expired cards - opened wishlist item here

[mkllnk]

Noticed some console errors which seem to be introduced by Stimulus

From the error message I would guess that when you use pagination to go to page 2, for example, and then reload the page, that it doesn't remember the page because the URL wasn't changed. Can you test that?

I don't think that it should block the release though.

[filipefurtad0]

From the error message I would guess that when you use pagination to go to page 2, for example, and then reload the page, that it doesn't remember the page because the URL wasn't changed. Can you test that?

Thanks @mkllnk . Yes, indeed that's the case - for both the new and the legacy BO design on the product edit page, hence not a regression. However, pagination is "remembered" on the admin/orders page, so I guess this is a bug concerning only the admin/products page.

[filipefurtad0]

Opened an S4 here, took the liberty of assigning it as good first issue, as we have this correctly implemented elsewhere (I'm assuming the makes the task easier).