-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rubocop Rails issues #11482
Comments
Hi @macanudo527 , I see you've started on this so created an issue for tracking. |
@dacook Can you assign this to me? |
Hi @macanudo527 , how have you been? I hope you've had a fulfilling start to the year! |
@dacook Yeah, I've just been too busy with everything. I'd like to work on it, but just can't. |
No problems, that's totally understandable. All the best for this season, and I hope to see you again soon! |
Great, yep, that's correct Anthony. Good luck! |
@dacook maybe we could create sub-issues of the task list in the description? We can create them as we go. Just click to the far right of each checkbox. |
Thanks Sigmund. Yes I hadn't bothered with this because I wasn't sure how big each of the items was. It's possible some are so small that they don't need to have a separate issue/pr.. |
@dacook I can work on some of this. Can it be assigned to me? |
@sigmundpetersen I can work on this, can it be assigned to me? |
Hi and welcome @Nwabor 👋 |
Thank you @sigmundpetersen. |
@sigmundpetersen i need access right to push my PR. |
@Nwabor you should not need right to create the PR, have a look at the documentation here : https://github.com/openfoodfoundation/openfoodnetwork/wiki/Making-a-great-pull-request . Make sure you are using your own fork. |
@sigmundpetersen can I pick another task, while waiting for the PR I pushed to be reviewed? |
Yes, go ahead @Nwabor 👍 |
Okay thanks, I will resolve the conflicts as well @sigmundpetersen |
- in relation to: Fix Rubocop Rails issues openfoodfoundation#11482 - and Require belongs_to associations by default openfoodfoundation#11297 - and openfoodfoundation#12407 openfoodfoundation#12428 etc.
We use Rubocop to standardise our code, which can improve code quality and reduce confusion. When evaluating each rule, consider if it helps with those goals or not. Often the suggested autocorrection is fine, but some cops require more consideration and there may be a better solution, or it might be appropriate to disable them, rather than create unnecessary extra work.
If unsure, please ping @openfoodfoundation/core-devs to request an opinion.
Strategy to fix issues
The normal process to fix a style issue is:
.rubocop_todo.yml
and run rubocop to see the error(s).rubocop:disable
comment in some cases (disable only offending line where possible)When a cop or group of cops is complete, open a pull request.
Issues
Most/all of these will require manual fixes.
Generated 27 Feb 2024:
The text was updated successfully, but these errors were encountered: