From 9b9e45915016c0fe0bfc7700ce00b7ab4f65ae77 Mon Sep 17 00:00:00 2001 From: David Cook Date: Tue, 23 Apr 2024 13:11:39 +1000 Subject: [PATCH] Add ability to bulk update products for product managers I forgot to do this in #12328 [BUU] Remove Stimulus Reflex from Products screen --- app/models/spree/ability.rb | 2 +- spec/system/admin/products_v3/products_spec.rb | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/app/models/spree/ability.rb b/app/models/spree/ability.rb index 037bfecdb6bd..e95d73b5fccb 100644 --- a/app/models/spree/ability.rb +++ b/app/models/spree/ability.rb @@ -192,7 +192,7 @@ def add_product_management_abilities(user) OpenFoodNetwork::Permissions.new(user).managed_product_enterprises.include? product.supplier end - can [:admin, :index], :products_v3 + can [:admin, :index, :bulk_update], :products_v3 can [:create], Spree::Variant can [:admin, :index, :read, :edit, diff --git a/spec/system/admin/products_v3/products_spec.rb b/spec/system/admin/products_v3/products_spec.rb index a4f2a3b139bd..d389c819a6dd 100644 --- a/spec/system/admin/products_v3/products_spec.rb +++ b/spec/system/admin/products_v3/products_spec.rb @@ -150,7 +150,6 @@ fill_in "Name", with: "Pommes" end - pending "#12403" expect { click_button "Save changes" @@ -179,14 +178,14 @@ search_by_category "Category 1" # expect(page).to have_content "1 product found for your search criteria." - expect(page).to have_select "category_id", selected: "Category 1" + expect(page).to have_select "category_id", selected: "Category 1" # succeeds in CI but not dev. expect_products_count_to_be 1 expect(page).to have_field "Name", with: product_by_category.name end end end - xdescribe "updating" do # pending #12403 + describe "updating" do let!(:variant_a1) { product_a.variants.first.tap{ |v| v.update! display_name: "Medium box", sku: "APL-01", price: 5.25, on_hand: 5,