Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag_release can crash with ReadTimeout when rolling back changes #397

Open
kdmccormick opened this issue Jun 14, 2023 · 0 comments
Open
Labels
bug Report of or fix for something that isn't working as intended

Comments

@kdmccormick
Copy link
Member

Description

Scenario: When rolling back changes, the tag_release script might hit a ReadTimeout, for whatever reason.

Desired behavior: When rolling back, any ReadTimeout would be handled by logging & re-trying. The re-trying would continue until the user manually cancelled the script with Ctrl-C.

Actual behavior: Script does not handle ReadTimeout; it crashes. Not all changes are rolled back.

Reproduction steps

???

Context

This issue is based on a memory and a brief note I made during the Nutmeg release. If this can't be reproduced or doesn't seem valuable to worry about, then feel free to close this.

@kdmccormick kdmccormick added the bug Report of or fix for something that isn't working as intended label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
None yet
Development

No branches or pull requests

1 participant