Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superset i18n: Fix language settings in echarts #300

Open
pomegranited opened this issue Nov 15, 2024 · 1 comment
Open

Superset i18n: Fix language settings in echarts #300

pomegranited opened this issue Nov 15, 2024 · 1 comment
Assignees
@pomegranited
Labels
aspects enhancement Relates to new features or improvements to existing features

Comments

@pomegranited
Copy link
Contributor

Description

When you switch language in Superset, some charts still have untranslated buttons.
For example Pie chart has 'All' and 'Inv' buttons, that are always on English.

Supporting information

apache/superset#30131

Proposed solution

Pass the current locale object to echart init, see comments from here apache/superset#30131 (comment)
@pomegranited pomegranited added enhancement Relates to new features or improvements to existing features aspects labels Nov 15, 2024
@pomegranited pomegranited self-assigned this Nov 15, 2024
@bmtcril
Copy link
Contributor

bmtcril commented Nov 15, 2024

Just noting that this is an upstream Superset enhancement, but is an improvement we want for Aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomegranited pomegranited

Labels
aspects enhancement Relates to new features or improvements to existing features
Projects
Data Working Group
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pomegranited @bmtcril