Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adds ADR 11. Course and block data #109

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

pomegranited
Copy link
Contributor

Description

Documents our decision to use an event sink to synchronize course and block data from Open edX to Clickhouse.

Supporting information

Part of #61

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 19, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@pomegranited pomegranited requested a review from bmtcril January 19, 2024 03:02
Base automatically changed from jill/adr-l10n to main January 19, 2024 17:57
@bmtcril
Copy link
Contributor

bmtcril commented Jan 19, 2024

Looks good once these warnings get fixed:

  • /home/docs/checkouts/readthedocs.org/user_builds/openedx-oars/checkouts/109/docs/decisions/0011_course_block_data.rst:36: ERROR: Unknown target name: "oep-50 hooks extension framework".
  • /home/docs/checkouts/readthedocs.org/user_builds/openedx-oars/checkouts/109/docs/decisions/0011_course_block_data.rst:55: ERROR: Unknown target name: "coursegraph".

I think we'll probably supersede this with one that uses the event bus instead of event sink eventually, but I don't think we need to speculate on that here. I was going to comment that we have some more general usages than just these, but I think you captured that at the end. 👍

@pomegranited pomegranited merged commit a7ce025 into main Jan 23, 2024
3 checks passed
@pomegranited pomegranited deleted the jill/adr-course-blocks branch January 23, 2024 00:33
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pomegranited pomegranited mentioned this pull request Jan 23, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants