-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: course creation button is inactive #508
fix: course creation button is inactive #508
Conversation
When using Tab to move from Org field to the next Course number field the Org value is not saved. Closes openedx/frontend-app-authoring#1199 for Redwood release.
Thanks for the pull request, @cmltaWt0! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5.x #508 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 248 248
Lines 4545 4545
Branches 940 939 -1
=======================================
Hits 4044 4044
Misses 468 468
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Shouldn't the PR be to the master branch? |
The redwood.master uses v2.5.1. That is far behind the current master (v2.7.0). |
Yeah, this whole situation is kinda confusing. Ideally we'd be merging to master then backporting to a properly configured |
@cmltaWt0, I've verified that the fix works, but let's try and do this right: can you please re-target this PR to |
Alternatively, if the main branch is too different, just retarget this PR to the |
I went ahead and merged it to 2.5.x directly. :) |
Thanks @arbrandes !! I didn't notice the branch and created a new one. |
In spite of the fact that the release job seems to have failed, it actually produced a 2.5.3: https://www.npmjs.com/package/@edx/frontend-lib-content-components/v/2.5.3 Looks like we're good here! Thanks, @cmltaWt0! |
When using Tab to move from Org field to the
next Course number field the Org value is not saved.
Closes openedx/frontend-app-authoring#1199 for Redwood release.
This fix differs from the one to the frontend-app-authoring since the value we want to save in DB should be raw (not normalized).
Fixed behavior:
Screen.Recording.2024-10-18.at.14.32.19.mov