Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course creation button is inactive #508

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

cmltaWt0
Copy link

When using Tab to move from Org field to the
next Course number field the Org value is not saved.

Closes openedx/frontend-app-authoring#1199 for Redwood release.

This fix differs from the one to the frontend-app-authoring since the value we want to save in DB should be raw (not normalized).

Fixed behavior:

Screen.Recording.2024-10-18.at.14.32.19.mov

When using Tab to move from Org field to the
next Course number field the Org value is not saved.

Closes openedx/frontend-app-authoring#1199 for
Redwood release.
@openedx-webhooks
Copy link

Thanks for the pull request, @cmltaWt0!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.97%. Comparing base (ebab15f) to head (eff1745).
Report is 3 commits behind head on 2.5.x.

Additional details and impacted files
@@           Coverage Diff           @@
##            2.5.x     #508   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         248      248           
  Lines        4545     4545           
  Branches      940      939    -1     
=======================================
  Hits         4044     4044           
  Misses        468      468           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arbrandes
Copy link
Contributor

Shouldn't the PR be to the master branch?

@cmltaWt0
Copy link
Author

cmltaWt0 commented Oct 18, 2024

Shouldn't the PR be to the master branch?

The redwood.master uses v2.5.1. That is far behind the current master (v2.7.0).
So I cut a branch from v2.5.2 to create a 2.5.3 release.
Do you feel like we can use the latest master with the redwood?

@arbrandes
Copy link
Contributor

Yeah, this whole situation is kinda confusing. Ideally we'd be merging to master then backporting to a properly configured v2.5.x branch that semantic-release would then pick up, but now that this repo is in maintenance mode, it might not be worth the effort. Let me think about it as I test the fix itself.

@arbrandes
Copy link
Contributor

arbrandes commented Oct 18, 2024

@cmltaWt0, I've verified that the fix works, but let's try and do this right: can you please re-target this PR to mastermain, and then create a backport PR to the 2.5.x branch I just set up?

@arbrandes
Copy link
Contributor

Alternatively, if the main branch is too different, just retarget this PR to the 2.5.x branch directly.

@arbrandes arbrandes changed the base branch from max/v2.5.3-release-preparation to 2.5.x October 18, 2024 19:04
@arbrandes arbrandes merged commit f230d64 into openedx:2.5.x Oct 18, 2024
7 checks passed
@arbrandes
Copy link
Contributor

I went ahead and merged it to 2.5.x directly. :)

@cmltaWt0
Copy link
Author

I went ahead and merged it to 2.5.x directly. :)

Thanks @arbrandes !! I didn't notice the branch and created a new one.

@arbrandes
Copy link
Contributor

In spite of the fact that the release job seems to have failed, it actually produced a 2.5.3:

https://www.npmjs.com/package/@edx/frontend-lib-content-components/v/2.5.3

Looks like we're good here! Thanks, @cmltaWt0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants