-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix rows counter in the Edit Grade modal window (olive branch) #311
fix: Fix rows counter in the Edit Grade modal window (olive branch) #311
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @Lunyachek! Is this duplicate of #310? |
@Lunyachek Nevermind - I see the different titles. :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #311 +/- ##
=============================================================
Coverage ? 100.00%
=============================================================
Files ? 109
Lines ? 1272
Branches ? 252
=============================================================
Hits ? 1272
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
e671904
to
06c3097
Compare
06c3097
to
5f5cb57
Compare
Hi @mattcarter - just following up on this for review/merge. Thanks! |
My apologies @mattcarter - it looks like Product needs to review first. |
Since this fix has multiple PRs associated with it (#310 and #311), I've created a Product Feature ticket. It's currently undergoing Product Review in that Product Feature Ticket. |
Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you! |
Hi @mattcarter - friendly ping on this :) |
HIi @mattcarter and @openedx/content-aurora! Would it be possible for someone to review/merge this? Thanks! |
Just checking in on this @openedx/content-aurora :) |
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting
What changed?
FYI: @openedx/content-aurora