Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix rows counter in the Edit Grade modal window (olive branch) #311

Conversation

Lunyachek
Copy link
Contributor

TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting

Снимок экрана 2023-02-10 в 15 25 06

What changed?

Снимок экрана 2023-02-10 в 15 42 01

FYI: @openedx/content-aurora

@Lunyachek Lunyachek requested a review from a team as a code owner February 10, 2023 14:10
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 10, 2023
@mphilbrick211
Copy link

Hi @Lunyachek! Is this duplicate of #310?

@mphilbrick211
Copy link

Hi @Lunyachek! Is this duplicate of #310?

@Lunyachek Nevermind - I see the different titles. :)

@jmakowski1123 jmakowski1123 added the product review PR requires product review before merging label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (open-release/olive.master@85709d9). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/olive.master      #311   +/-   ##
=============================================================
  Coverage                             ?   100.00%           
=============================================================
  Files                                ?       109           
  Lines                                ?      1272           
  Branches                             ?       252           
=============================================================
  Hits                                 ?      1272           
  Misses                               ?         0           
  Partials                             ?         0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lunyachek Lunyachek force-pushed the lunyachek/fix/edit-grades-modal-rows-counter branch from e671904 to 06c3097 Compare February 14, 2023 13:03
@Lunyachek Lunyachek force-pushed the lunyachek/fix/edit-grades-modal-rows-counter branch from 06c3097 to 5f5cb57 Compare February 17, 2023 19:07
@mphilbrick211
Copy link

Hi @mattcarter - just following up on this for review/merge. Thanks!

@mphilbrick211
Copy link

Hi @mattcarter - just following up on this for review/merge. Thanks!

My apologies @mattcarter - it looks like Product needs to review first.
CC: @jmakowski1123 @ProductRyan

@jmakowski1123
Copy link

jmakowski1123 commented Feb 22, 2023

Since this fix has multiple PRs associated with it (#310 and #311), I've created a Product Feature ticket. It's currently undergoing Product Review in that Product Feature Ticket.

@mphilbrick211
Copy link

Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!

@mphilbrick211
Copy link

Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!

Hi @mattcarter - friendly ping on this :)

@mphilbrick211
Copy link

HIi @mattcarter and @openedx/content-aurora! Would it be possible for someone to review/merge this? Thanks!

@mphilbrick211
Copy link

HIi @mattcarter and @openedx/content-aurora! Would it be possible for someone to review/merge this? Thanks!

Just checking in on this @openedx/content-aurora :)

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 2, 2023
@leangseu-edx leangseu-edx merged commit 395a6d0 into openedx:open-release/olive.master Oct 10, 2023
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants