From 46727208a1e6840847e9392c12e80ac297a3eb41 Mon Sep 17 00:00:00 2001 From: Felipe Montoya Date: Thu, 11 Apr 2024 15:26:04 -0500 Subject: [PATCH 1/3] fix: comparing values to actual bool instead of string --- src/CourseAuthoringRoutes.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/CourseAuthoringRoutes.jsx b/src/CourseAuthoringRoutes.jsx index 1f02383030..2bc49e7187 100644 --- a/src/CourseAuthoringRoutes.jsx +++ b/src/CourseAuthoringRoutes.jsx @@ -82,11 +82,11 @@ const CourseAuthoringRoutes = () => { ))} : null} + element={getConfig().ENABLE_NEW_EDITOR_PAGES === true ? : null} /> : null} + element={getConfig().ENABLE_NEW_EDITOR_PAGES === true ? : null} /> Date: Wed, 24 Apr 2024 12:56:06 -0500 Subject: [PATCH 2/3] fix: removing checks as per PR discussion --- src/CourseAuthoringRoutes.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/CourseAuthoringRoutes.jsx b/src/CourseAuthoringRoutes.jsx index 2bc49e7187..ed6858b677 100644 --- a/src/CourseAuthoringRoutes.jsx +++ b/src/CourseAuthoringRoutes.jsx @@ -82,11 +82,11 @@ const CourseAuthoringRoutes = () => { ))} : null} + element={} /> : null} + element={} /> Date: Wed, 24 Apr 2024 13:51:20 -0500 Subject: [PATCH 3/3] chore: cleanup after removing the checks --- .env | 1 - .env.development | 1 - .env.test | 1 - README.rst | 7 ------- src/index.jsx | 1 - 5 files changed, 11 deletions(-) diff --git a/.env b/.env index 6d91485e58..e5fa2f49a9 100644 --- a/.env +++ b/.env @@ -30,7 +30,6 @@ USER_INFO_COOKIE_NAME='' ENABLE_ACCESSIBILITY_PAGE=false ENABLE_PROGRESS_GRAPH_SETTINGS=false ENABLE_TEAM_TYPE_SETTING=false -ENABLE_NEW_EDITOR_PAGES=true ENABLE_UNIT_PAGE=false ENABLE_ASSETS_PAGE=false ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN=false diff --git a/.env.development b/.env.development index 279bbaedae..664b0f9a42 100644 --- a/.env.development +++ b/.env.development @@ -32,7 +32,6 @@ USER_INFO_COOKIE_NAME='edx-user-info' ENABLE_ACCESSIBILITY_PAGE=false ENABLE_PROGRESS_GRAPH_SETTINGS=false ENABLE_TEAM_TYPE_SETTING=false -ENABLE_NEW_EDITOR_PAGES=true ENABLE_UNIT_PAGE=false ENABLE_ASSETS_PAGE=false ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN=false diff --git a/.env.test b/.env.test index cbdb4821cd..7d74809b47 100644 --- a/.env.test +++ b/.env.test @@ -28,7 +28,6 @@ SUPPORT_URL='https://support.edx.org' USER_INFO_COOKIE_NAME='edx-user-info' ENABLE_PROGRESS_GRAPH_SETTINGS=false ENABLE_TEAM_TYPE_SETTING=false -ENABLE_NEW_EDITOR_PAGES=true ENABLE_UNIT_PAGE=true ENABLE_ASSETS_PAGE=false ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN=true diff --git a/README.rst b/README.rst index 724d9dfc78..e62b777d10 100644 --- a/README.rst +++ b/README.rst @@ -140,13 +140,6 @@ Requirements * ``new_core_editors.use_new_video_editor``: must be enabled for the new Video Xblock editor to be used in Studio * ``new_core_editors.use_new_problem_editor``: must be enabled for the new Problem Xblock editor to be used in Studio -Configuration -------------- - -In additional to the standard settings, the following local configuration item is required: - -* ``ENABLE_NEW_EDITOR_PAGES``: must be enabled in order to actually present the new XBlock editors (on by default) - Feature Description ------------------- diff --git a/src/index.jsx b/src/index.jsx index f717df4c02..c35a471403 100755 --- a/src/index.jsx +++ b/src/index.jsx @@ -120,7 +120,6 @@ initialize({ PRIVACY_POLICY_URL: process.env.PRIVACY_POLICY_URL || null, ENABLE_ACCESSIBILITY_PAGE: process.env.ENABLE_ACCESSIBILITY_PAGE || 'false', NOTIFICATION_FEEDBACK_URL: process.env.NOTIFICATION_FEEDBACK_URL || null, - ENABLE_NEW_EDITOR_PAGES: process.env.ENABLE_NEW_EDITOR_PAGES || 'false', ENABLE_UNIT_PAGE: process.env.ENABLE_UNIT_PAGE || 'false', ENABLE_ASSETS_PAGE: process.env.ENABLE_ASSETS_PAGE || 'false', ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN: process.env.ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN || 'false',