Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set original value for TypeaheadDropdown component #1402

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: set original value for TypeaheadDropdown component #1402

merged 1 commit into from
Oct 18, 2024

Conversation

cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented Oct 18, 2024 •
edited
Loading

Related to #1199

In TypeaheadDropdown component we set a normalized value instead of original one.
As a result - a lowercased value is saved into DB.

Test instruction:

  • go to Home page
  • click create new course
  • type organization with upper case
  • use TAB to move to the next field
  • fill a Course number
  • fill the Course run
  • create course

AR:

  • the Org is create in Lower case

ER:

  • the org is create in original Upper case

@cmltaWt0 cmltaWt0 requested a review from a team as a code owner October 18, 2024 12:18
@openedx-webhooks
Copy link

Thanks for the pull request, @cmltaWt0!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 18, 2024
@cmltaWt0 cmltaWt0 requested a review from arbrandes October 18, 2024 12:18
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (4facf1c) to head (ab14d34).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1402   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files        1047     1047           
  Lines       20138    20138           
  Branches     4201     4201           
=======================================
  Hits        18748    18748           
  Misses       1328     1328           
  Partials       62       62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mariajgrimaldi
mariajgrimaldi reviewed Oct 18, 2024
View reviewed changes
src/editors/sharedComponents/TypeaheadDropdown/index.jsx
@@ -90,7 +90,7 @@ class TypeaheadDropdown extends React.Component {
this.setValue(opt);
this.setState({ displayValue: opt });
} else {
this.setValue(normalized);
this.setValue(value);
Copy link
Member

@mariajgrimaldi mariajgrimaldi Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's done in L90 for existent orgs, saving the value instead looks like the right thing to do for the newly created. Thank you!

mariajgrimaldi
mariajgrimaldi approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbrandes
Copy link
Contributor

I cannot reproduce this problem on master. Created a TestOrg via the new course page in the authoring MFE, and TestOrg is what I see. Is there anything else I'm missing?

arbrandes
arbrandes requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot reproduce.

@cmltaWt0
Copy link
Contributor Author

@arbrandes The issue can be reproduced via TAB control - when we want to move to the next field (accessibility related action). I've described it in the Redwood PR only (sorry, I'll update the STR).

There is a video to picture the flow:

Screen.Recording.2024-10-18.at.17.55.11.mov

arbrandes
arbrandes approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I was able to reproduce the issue using the keyboard! Not only that, this does indeed fix the problem. Thanks, approved!

@arbrandes arbrandes merged commit a94df2f into openedx:master Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

@arbrandes arbrandes arbrandes approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmltaWt0 @openedx-webhooks @arbrandes @mariajgrimaldi