Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create button remains deactivated until pick a new org #1279

Merged

Conversation

DmytroAlipov
Copy link
Contributor

Description

The fix concerns this issue. Specifically the case when switching between fields is done using the Tab button.

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner September 13, 2024 14:51
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 13, 2024
@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (fd48fef) to head (8af328c).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   92.31%   92.73%   +0.42%     
==========================================
  Files        1013     1050      +37     
  Lines       18733    20051    +1318     
  Branches     3947     4307     +360     
==========================================
+ Hits        17293    18594    +1301     
- Misses       1374     1388      +14     
- Partials       66       69       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroAlipov
Copy link
Contributor Author

Hi @KristinAoki
Could you please review this MR? This is related to the issue, specifically to this case. If this solution is okay, I will backport it to Redwood so the fix can be included in the Redwood-3 release.

@DmytroAlipov DmytroAlipov reopened this Sep 23, 2024
@arbrandes arbrandes self-requested a review September 23, 2024 15:18
@KristinAoki KristinAoki merged commit c80483c into openedx:master Sep 27, 2024
11 checks passed
@DmytroAlipov DmytroAlipov deleted the fix-create-button-deactivated branch September 27, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants