Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0059] UI fixes on create content #1198

Merged

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jul 31, 2024

Description

This PR adds:

  • Hide the "New" button on the read-only state of a library.
  • Hide the "Add component" buttons on the read-only state of a library.
  • Add "Read only" badge on the read-only state of a library.

image

Supporting information

Testing instructions

  • Go to Studio and create a new library
  • Enable public read of the library in cms bash:
from openedx.core.djangoapps.content_libraries.models import ContentLibrary
lib = ContentLibrary.objects.all()[0]
lib.allow_public_read = True
lib.save()
  • Create and login with a new normal user (not staff).
  • Go to the library home using the id of your new library
  • Verify that the New button is hidden.
  • Verify that all Add component buttons in empty states are hidden.
  • Verify that you can see the "Read only" badge.

@ChrisChV ChrisChV requested a review from a team as a code owner July 31, 2024 19:12
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 31, 2024
@ChrisChV ChrisChV changed the title Chris/UI fixes on create content [FC-0059] UI fixes on create content Jul 31, 2024
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (cba85ab) to head (79154a4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
+ Coverage   92.88%   92.91%   +0.02%     
==========================================
  Files         750      750              
  Lines       13468    13488      +20     
  Branches     2930     2884      -46     
==========================================
+ Hits        12510    12532      +22     
+ Misses        923      921       -2     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


return (
<Stack direction="horizontal" gap={3} className="mt-6 justify-content-center">
<Stack direction="horizontal" gap={3} className="mt-6 just ify-content-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Stack direction="horizontal" gap={3} className="mt-6 just ify-content-center">
<Stack direction="horizontal" gap={3} className="mt-6 justify-content-center">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, It's my keyboard's fault 😆

Fixed: 79154a4

@ChrisChV
Copy link
Contributor Author

ChrisChV commented Aug 2, 2024

@bradenmacdonald It's ready for another review

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: as described
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@bradenmacdonald bradenmacdonald merged commit a7645af into openedx:master Aug 8, 2024
7 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the chris/UI-fixes-on-create-content branch August 8, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants