Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect field validation on the Course Grading page #1059

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented May 30, 2024

Description

  • Possible save just space forAssignment type name
  • Possible save Number of droppable field with values more than the Total number value which leads to displaying errors all the time
  • Possible save Weight of total grade field with empty values:
    image
    Implemented so that when an error occurs, the modal window containing the Save changes button is not displayed:
    image
    Fixed display of errors for the Number of droppable field:
    image

Steps to Reproduce:

Open studio -> any course -> Settings -> Grading
Check Assignment types fields validation

@PKulkoRaccoonGang PKulkoRaccoonGang requested a review from a team as a code owner May 30, 2024 11:47
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 30, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 30, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft May 30, 2024 11:47
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title Fix valdate assignment types fix: incorrect field validation on the Course Grading page May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (1dde30a) to head (0f13587).
Report is 773 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
+ Coverage   91.93%   92.52%   +0.58%     
==========================================
  Files         572      708     +136     
  Lines       10166    12595    +2429     
  Branches     2199     2769     +570     
==========================================
+ Hits         9346    11653    +2307     
- Misses        793      907     +114     
- Partials       27       35       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this May 30, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label May 30, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 30, 2024 13:13
@PKulkoRaccoonGang
Copy link
Contributor Author

Old PR: #919

@PKulkoRaccoonGang
Copy link
Contributor Author

@jesperhodge hi! As you requested, we have added a new test .
Please take a look again

@KristinAoki
Copy link
Member

KristinAoki commented Jun 4, 2024

I just tested the code again and I no longer see the error for when the number of assignments is less that number of droppables. The expected error is shown when I change the droppable count. The case captured below is when I only change the total count.
Screenshot 2024-06-04 at 10 35 06 AM

@KristinAoki
Copy link
Member

@PKulkoRaccoonGang here is a recording of the observed behavior

Screen.Recording.2024-06-04.at.10.38.51.AM.mov

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@mphilbrick211
Copy link

Hi @PKulkoRaccoonGang and @KristinAoki! Is this still in progress?

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft August 6, 2024 09:37
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang PKulkoRaccoonGang closed this by deleting the head repository Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants