Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course outline page: Weird alignment happening on the highlights feature #986

Open
jmakowski1123 opened this issue May 7, 2024 · 4 comments
Labels
release testing Affects the upcoming release (attention needed)

Comments

@jmakowski1123
Copy link

When I add highlights to a section in the course outline, the field for the fifth highlight and the save/cancel buttons spill off the modal

Screen Shot 2024-05-07 at 12 22 51 PM
@jmakowski1123 jmakowski1123 added the release testing Affects the upcoming release (attention needed) label May 7, 2024
@mariajgrimaldi
Copy link
Member

FYI @arbrandes @brian-smith-tcril @openedx/teaching-and-learning, please tag anyone who can help with this issue.

@KristinAoki
Copy link
Member

@brian-smith-tcril I looked at this issue and it appears to be a paragon issues. I was able to reproduce the issue on the doc site when I made it so that the content in ModalDialog.Body overflowed.

@brian-smith-tcril
Copy link
Contributor

Ah, yes. Overflow in the modals isn't being handled in the most elegant way at the moment. The issue with the autosuggest component not overflowing was resolved by a PR - but there were conversations around developing a more robust solution that made it into another Paragon issue.

It's clear that the content overflowing out of the modal without a background isn't expected behavior. If having a scrollbar in the modal is an acceptable solution then setting isOverflowVisible={false} should do the trick, but in general default values shouldn't lead to unexpected behavior like this. I've created an issue on the Paragon repo to discuss how to best handle this prop without leading to the aforementioned unexpected behavior.

@mariajgrimaldi mariajgrimaldi moved this from Backlog to In progress in Build-Test-Release Working Group Aug 23, 2024
@mariajgrimaldi
Copy link
Member

Thank you for the update, @brian-smith-tcril. Since you're working on a solution, I'll assign you this issue for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed)
Projects
Status: In progress
Development

No branches or pull requests

4 participants