Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Home - Filter by Capa Problem Type #1196

Closed
bradenmacdonald opened this issue Jul 30, 2024 · 11 comments
Closed

Library Home - Filter by Capa Problem Type #1196

bradenmacdonald opened this issue Jul 30, 2024 · 11 comments

Comments

@bradenmacdonald
Copy link
Contributor

Update the "Type" filter to allow optionally filtering by more specific capa problem type.

Note that this data is already in the search index.

Screenshot

@bradenmacdonald
Copy link
Contributor Author

@ChrisChV Somehow we missed this in #1049 so we need to do it now. Can you please create the FAL ticket for it?

@bradenmacdonald
Copy link
Contributor Author

@jmakowski1123 If it doesn't require any additional work, would you like us to implement this detailed capa filtering on the Studio course search modal too, or just in libraries?

@ChrisChV
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts Just one question about the filter behavior: Is it necessary to add the filter related data in the type filter?

image

Like this?

image

(ref)

@bradenmacdonald
Copy link
Contributor Author

@ChrisChV Can you clarify what you're asking? I'm not really sure what you mean.

@ChrisChV
Copy link
Contributor

ChrisChV commented Aug 26, 2024

In the Type button when you select a component type, that type appears on the button text. Do we expect the same for the problems types?

https://www.loom.com/share/2ad01436fa13478abec6dc3a2fb9e0a3?sid=ec3247a8-362d-4074-b874-668f0b599562

@bradenmacdonald
Copy link
Contributor Author

@ChrisChV Good question. Personally, I think it should appear there too. It would usually just be a number though e.g. "Problem (+2)" or "Multiple Choice (+3)"

@ChrisChV
Copy link
Contributor

Good question. Personally, I think it should appear there too. It would usually just be a number though e.g. "Problem (+2)" or "Multiple Choice (+3)"

Thanks! I updated this on #1207

@ChrisChV
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

You can test it with this library

@ChrisChV ChrisChV moved this from Backlog to Ready for AC testing in Libraries Overhaul Sep 2, 2024
@lizc577
Copy link

lizc577 commented Sep 10, 2024

I noticed a minor inconsistency with the 'select all' functionality. If you select a few problem types, then click select all, then leave the dropdown. re-open the drop down and de-select some, the main "problem" filter will look as if none are selected.

Screenshare.-.2024-09-09.6_04_43.PM.mp4

@ChrisChV
Copy link
Contributor

I noticed a minor inconsistency with the 'select all' functionality. If you select a few problem types, then click select all, then leave the dropdown. re-open the drop down and de-select some, the main "problem" filter will look as if none are selected.

@jmakowski1123 @lizc577 @sdaitzman @marcotuts Fixed! You can check it on the sandbox.

@lizc577
Copy link

lizc577 commented Sep 19, 2024

Looks good!

@github-project-automation github-project-automation bot moved this from Ready for AC testing to Done in Libraries Overhaul Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants