Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace progress bar with loading spinner #1192

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

KristinAoki
Copy link
Member

Description

This change removes the progress bar from the video upload modal and replaces it with text and a spinner. The progress bar was unable to be updated based on the progress of the AWS api connection and would always remain empty even when competed. To prevent user confusion a spinner and text changes are now used to indicate upload progress.

Before

Screenshot 2024-07-30 at 2 15 23 PM

After

Screenshot 2024-07-30 at 2 18 09 PM

Supporting information

JIRA Ticket: TNL-11671 🔒

Testing instructions

  1. Navigate to the videos page
  2. Click "Add Videos"
  3. Select multiple videos
  4. Check that the videos go through the following stages
    i. Queued
    ii. Uploading
    iii. Failed or Check icon

@KristinAoki KristinAoki requested a review from rayzhou-bit July 30, 2024 19:59
@KristinAoki KristinAoki requested a review from a team as a code owner July 30, 2024 19:59
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (3a14141) to head (1465b93).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
+ Coverage   92.68%   92.89%   +0.20%     
==========================================
  Files         693      750      +57     
  Lines       12346    13477    +1131     
  Branches     2661     2933     +272     
==========================================
+ Hits        11443    12519    +1076     
- Misses        872      922      +50     
- Partials       31       36       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki enabled auto-merge (squash) August 2, 2024 15:54
Copy link
Contributor

@bszabo bszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean!

@KristinAoki KristinAoki merged commit 7379e73 into master Aug 7, 2024
7 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/replace-progress-bar-with-spinner branch August 7, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants