Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections Page - Filter by Tags #1169

Closed
jmakowski1123 opened this issue Jul 17, 2024 · 4 comments
Closed

Collections Page - Filter by Tags #1169

jmakowski1123 opened this issue Jul 17, 2024 · 4 comments

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Jul 17, 2024

If a Collection has content populated in it, users can filter that content using tags.

Screen Shot 2024-07-17 at 3 55 44 PM

See implementation details for filtering by tags at the Library level: #1048. A similar implementation needs to happen at the Collection level, but the filtering is limited to content contained within the Collection.

@kdmccormick kdmccormick transferred this issue from openedx-unsupported/frontend-app-library-authoring Jul 18, 2024
@navinkarkera navinkarkera moved this from Backlog to Ready for AC testing in Libraries Overhaul Sep 24, 2024
@navinkarkera
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox

@jmakowski1123
Copy link
Author

jmakowski1123 commented Sep 24, 2024

I would expect that when I select a child tag in the filter, that the implicit parent tag would auto-select at the same time? This mirrors the behavior when tags are added to content. I'm trying to check the current behavior in the course search but it's not working on our instance for some reason. @bradenmacdonald is that your interpretation too? Wouldn't the search parameters technically be "Description Status AND Libraries Relaunch Taxonomy"?

Screen Shot 2024-09-24 at 3 29 05 PM

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 24, 2024

@jmakowski1123 Technically there is no difference between "Description Status AND Libraries Relaunch Taxonomy" and just searching "Description Status" - because it's impossible for a component to have "Description Status" without also having the parent tag. So I think what's there is correct.

You can also argue it would be correct to display a semi-checked checkbox Screenshot 2024-09-24 at 3 28 03 PM on the parent, and I think that's reasonable though personally I wouldn't bother. I wouldn't recommend putting a full checkbox Screenshot 2024-09-24 at 3 27 48 PM on that parent, because that usually implies all the child tags are selected, and they're not.

I'm trying to check the current behavior in the course search but it's not working on our instance for some reason

What page is not working - can you let me know? It should be working.

@jmakowski1123
Copy link
Author

Got it. This good.

@jmakowski1123 jmakowski1123 moved this from Ready for AC testing to Done in Libraries Overhaul Sep 30, 2024
@jmakowski1123 jmakowski1123 closed this as completed by moving to Done in Libraries Overhaul Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants