Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source map warning seen during build #1150

Merged

Conversation

bradenmacdonald
Copy link
Contributor

Description

We include a file (react-ranger.js) that is already sort of transpiled, minified, etc. It references a source map that doesn't exist, resulting in this warning seen during npm run build:

WARNING in ./src/grading-settings/grading-scale/react-ranger.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from 'frontend-app-course-authoring/src/grading-settings/grading-scale/react-ranger.mjs.map' file: Error: ENOENT: no such file or directory, open 'frontend-app-course-authoring/src/grading-settings/grading-scale/react-ranger.mjs.map'
 @ ./src/grading-settings/grading-scale/GradingScale.jsx 11:0-43 152:6-15
 @ ./src/grading-settings/GradingSettings.jsx 21:0-56 160:46-58
 @ ./src/grading-settings/index.js 2:0-63 2:0-63
 @ ./src/CourseAuthoringRoutes.jsx 15:0-53 129:38-53
 @ ./src/index.jsx 12:0-60 55:33-54

This is not a big problem, but it's nice to get rid of these sort of warnings if we can.

@bradenmacdonald bradenmacdonald requested a review from a team as a code owner July 10, 2024 13:58
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 10, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (71fcf9f) to head (1d51339).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1150   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files         693      693           
  Lines       12347    12347           
  Branches     2661     2694   +33     
=======================================
  Hits        11444    11444           
  Misses        872      872           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit cc41a2f into openedx:master Jul 11, 2024
7 checks passed
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@bradenmacdonald bradenmacdonald deleted the braden/fix-source-map-warning branch July 12, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants