-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds filter by tags and contentType to library home [FC-0059] #1141
feat: adds filter by tags and contentType to library home [FC-0059] #1141
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 693 693
Lines 12342 12342
Branches 2661 2694 +33
=======================================
Hits 11439 11439
Misses 872 872
Partials 31 31 ☔ View full report in Codecov by Sentry. |
07b3a03
to
dfd3190
Compare
2672082
to
c453ef0
Compare
@rpenido This PR should be unblocked now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this file with .ts
extension didn't work.
I was getting the following error:
export 'CreateLibrary' (imported as 'CreateLibrary') was not found in './library-authoring' (module has no exports)
Renaming to .tsx
or js
fixed the issue. I don't know why. I'm not sure if the problem is in my stack.
f591fbe
to
3d66e47
Compare
Hi @bradenmacdonald ! |
3d66e47
to
317c3e7
Compare
Refactor to add search-manager feature. Co-authored-by: Yusuf Musleh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, @rpenido - thanks!
I tested this on the library home page and the course search modal.
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@rpenido Was there a reason you squashed this PR by the way? I think that makes it a lot harder for @pomegranited to rebase her PR now, because the recent commits you've added are kind of lost in the squash. |
Hi @bradenmacdonald! I have the following backup branch before the squash. I created a PR handling the conflicts here, but it still needs some work (I may have accidentally removed something): I'm really sorry @pomegranited 😞 |
Thanks @rpenido ! It's not a big deal, but having the unsquashed branch makes it easier to merge in, especially because you had already done the work of updating your branch with the latest master. |
Description
This PR adds filters (tag and block type) to the content library home. It also includes a refactor to create a
search-manager
feature with hooks and components that can be reused while querying the meilisearch index.More Info:
Private ref: FAL-3763 and FAL-3764