Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current text editor in Libraries #1090

Closed
jmakowski1123 opened this issue Jun 11, 2024 · 9 comments
Closed

Use current text editor in Libraries #1090

jmakowski1123 opened this issue Jun 11, 2024 · 9 comments

Comments

@jmakowski1123
Copy link

jmakowski1123 commented Jun 11, 2024

"As a Library Author, I expect to have the exact same experience when creating and editing text in Libraries as I do in Courses."

Libraries utilize the same rich text editor as courses.

The Text Editor can be accessed from the following places in the UI:

  • When I click the "new button" and the "add content sidebar" opens and I click on "text", then the text editor modal pops up and I can create a new text component
  • In the component card, when I click on the 3-dot menu and then when I click on "edit" in the 3 dot menu, then the text editor for that component pops up, and I can make edits or adjustments to that component
  • In the header of the component sidebar, when I click on the "edit" button, then the text editor for that component pops up, and I can make edits or adjustments to that component

Image

Image

Image

@bradenmacdonald
Copy link
Contributor

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox. Any "Text" component should be editable.

However, there is a known issue where the search results don't update after you save changes. So when you edit a component, then click save, the card in the library view won't update right away. It will only update after you refresh the page or if you wait some time. Sorry I didn't catch this sooner - it only affects the sandbox, not our dev environments.

@bradenmacdonald
Copy link
Contributor

However, there is a known issue where the search results don't update after you save changes.

That issue is now fixed :)

@lizc577
Copy link

lizc577 commented Sep 19, 2024

Editing text component looks good!
One thing I noticed, when adding a link in the text editor, the link is not active in the sidebar preview. (It is active in the expanded view).
Also, not sure if this belongs on this ticket, but when editing a component, them pressing save, I land in the library with the library sidebar open. I should land back in the library with the component that I just saved still selected and its sidebar open.

@jmakowski1123
Copy link
Author

Couple issues in testing the editor:

  • Insert links doesn't seem to work. The modal opens and the fields are editable, but when you click save, the link doesn't embed
  • Embedding iframes turns up an error
  • General saving of the block turns up an error
Screen Shot 2024-09-23 at 2 27 55 PM Screen Shot 2024-09-23 at 2 30 10 PM Screen Shot 2024-09-23 at 2 30 43 PM

@bradenmacdonald
Copy link
Contributor

@lizc577

One thing I noticed, when adding a link in the text editor, the link is not active in the sidebar preview. (It is active in the expanded view).

Currently something is blocking any clicks on the sidebar preview for any component. I've mentioned that on #1189 (comment) and we can follow up there.

when editing a component, them pressing save, I land in the library with the library sidebar open. I should land back in the library with the component that I just saved still selected and its sidebar open.

Yeah, that's annoying. I have a separate ticket for that now: #1321

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 24, 2024

@jmakowski1123

Insert links doesn't seem to work. The modal opens and the fields are editable, but when you click save, the link doesn't embed
Embedding iframes turns up an error
General saving of the block turns up an error

Hmm, I tried all of those things now and didn't get the same issue. Here you can see how the editor looks after I already saved changes once and re-opened it:

Screenshot

Then I went and re-created your component from the screenshot in this library - look for "Text with lots of features". Can you try editing that and see if it's working?

Screenshot 2024-09-24 at 2 23 51 PM

@jmakowski1123
Copy link
Author

Yep, all three issues are working now!

@bradenmacdonald
Copy link
Contributor

@jmakowski1123 @lizc577 OK great. Let me know if you find any other issues, or if we can close this out for now.

@jmakowski1123
Copy link
Author

This can be closed I think

@jmakowski1123 jmakowski1123 moved this from Ready for AC testing to Done in Libraries Overhaul Sep 30, 2024
@jmakowski1123 jmakowski1123 closed this as completed by moving to Done in Libraries Overhaul Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants