-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect field validation on the Course Grading page #1059
fix: incorrect field validation on the Course Grading page #1059
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
+ Coverage 91.93% 92.52% +0.58%
==========================================
Files 572 708 +136
Lines 10166 12595 +2429
Branches 2199 2769 +570
==========================================
+ Hits 9346 11653 +2307
- Misses 793 907 +114
- Partials 27 35 +8 ☔ View full report in Codecov by Sentry. |
Old PR: #919 |
@jesperhodge hi! As you requested, we have added a new test . |
@PKulkoRaccoonGang here is a recording of the observed behavior Screen.Recording.2024-06-04.at.10.38.51.AM.mov |
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
Hi @PKulkoRaccoonGang and @KristinAoki! Is this still in progress? |
Sandbox deployment successful 🚀 |
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
Description
forAssignment
type nameNumber of droppable
field with values more than the Total number value which leads to displaying errors all the timeWeight of total grade
field with empty values:Implemented so that when an error occurs, the modal window containing the Save changes button is not displayed:
Fixed display of errors for the Number of droppable field:
Steps to Reproduce:
Open studio -> any course -> Settings -> Grading
Check Assignment types fields validation