Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course outline — issue when editing Section/Subsection/Unit name, and executing an action on the page #1056

Open
GlugovGrGlib opened this issue May 29, 2024 · 6 comments
Labels
release testing Affects the upcoming release (attention needed)

Comments

@GlugovGrGlib
Copy link
Member

Description

When editing a Section/Subsection/Unit name and clicking on an action on the page (such as New Section, New Subsection, or New Unit) without exiting the editing interface, some unexpected issues occur.

Expected Result

  • The new name for the Section/Subsection/Unit that the user entered is saved when the user clicks outside of the text field.
  • If the user clicks on the action button while editing a name for a course outline element, the name value should be saved, and the action should be executed correctly.

Actual Result

Editing Section Name and Executing Other Actions in the Current Section

  • When the user edits a Section name and clicks on actions in this section (such as New Section, New Subsection, or New Unit), the action is executed, but the new Section name isn't saved (the old value is displayed).

Editing Section/Subsection Name and Executing Actions in a Different Section

  • When the user edits a Section name and clicks on actions in different sections (such as New Section or New Subsection), the action isn't executed, but the new Section name is saved (the new value is displayed).
  • When the user edits a Section name and clicks on the New Unit action, the new Section name is saved (the new value is displayed), but the user sees a blank page.
Screenshot 2024-05-29 at 22 07 30

Additional details

Video:

Course.Outline.Issues.with.Name.field.mp4
@GlugovGrGlib GlugovGrGlib added the release testing Affects the upcoming release (attention needed) label May 29, 2024
@ichintanjoshi
Copy link

I have seen this in native too. This wasn't happening in koa (in native studio), but it was happening in olive (checked in native only), wasn't able to figure it out though.

I thought it was related to ajax or queries timing etc, but wasn't able to get it solved then.

@mariajgrimaldi
Copy link
Member

FYI @arbrandes @brian-smith-tcril @openedx/teaching-and-learning, please tag anyone who can help with this issue.

@brian-smith-tcril
Copy link
Contributor

I wasn't able to reproduce the issue when trying on the redwood sandbox, but I ran into another (possibly related) issue:

Repro Steps:

  • Create a new section
  • Edit the section title
  • Click on "New Subsection" while the section title is still in edit mode

Expected Behavior:

  • Section title saves
  • One new subsection created

Observed Behavior:

  • Section title saves
  • What seems like 2 new subsections are created
    • However, deleting one deletes both, so it seems like it's not actually creating 2
Screencast.from.2024-06-03.12-35-50.webm

@rayzhou-bit
Copy link
Contributor

I reproduced this in edx.org's production environment. Here's what I see on the network tab for the 2 scenarios:

  • Editing Section Name and Executing Other Actions in the Current Section: Name change POST hits a 500 error.
  • Editing Section/Subsection Name and Executing Actions in a Different Section: We never make a POST for the action.

I'll put this bug in teaching-and-learning's backlog.

@mariajgrimaldi
Copy link
Member

Thank you for the visibility, @rayzhou-bit. Do you have an update on this issue? Let us know!

@rayzhou-bit
Copy link
Contributor

@mariajgrimaldi This is still in our backlog and there's been no work on it. I'll check with our product manager on prioritization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed)
Projects
Status: Backlog
Development

No branches or pull requests

5 participants