Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course outline - subsection hiding function not working properly #1020

Open
jmakowski1123 opened this issue May 20, 2024 · 15 comments
Open

Course outline - subsection hiding function not working properly #1020

jmakowski1123 opened this issue May 20, 2024 · 15 comments
Assignees
Labels
bug Report of or fix for something that isn't working as intended release testing Affects the upcoming release (attention needed)

Comments

@jmakowski1123
Copy link

jmakowski1123 commented May 20, 2024

On the Redwood test branch, when I configure a subsection to "hide content after due date", I expect to see the notice "subsection is hidden after due date" and that the content will not be visible to learners after the due date.

Expected:

Screen Shot 2024-05-20 at 2 38 47 PM

However, when I click the dial to "hide content after due date", instead I see the notice that the "subsection is hidden after course end date", and thus the content is still visible to learners even if the due date has passed.

Screen Shot 2024-05-20 at 2 37 11 PM Screen Shot 2024-05-20 at 2 37 30 PM
@jmakowski1123 jmakowski1123 added the release testing Affects the upcoming release (attention needed) label May 20, 2024
@jmakowski1123 jmakowski1123 added the release blocker Blocks the upcoming release (fix needed) label May 24, 2024
@mariajgrimaldi
Copy link
Member

FYI @arbrandes @brian-smith-tcril @openedx/teaching-and-learning, please tag anyone who can help.

@brian-smith-tcril brian-smith-tcril self-assigned this May 30, 2024
@brian-smith-tcril
Copy link
Contributor

This appears to be working as expected on the redwood testing sandbox

https://apps.redwood.demo.edly.io/course-authoring/course/course-v1:Test+test8675309+test8675309

image

@brian-smith-tcril
Copy link
Contributor

@jmakowski1123 ^

@brian-smith-tcril
Copy link
Contributor

I did a bit more digging and I think I have a bit more context on this now.

https://github.com/openedx/frontend-app-course-authoring/blob/a585a13e97df9272f862de1392a2463fb74f93c3/src/course-outline/xblock-status/HideAfterDueMessage.jsx#L17-L19

It seems the message shows "hidden after course end date" if the course is self-paced, but the Subsection settings -> Visibility -> Subsection visibility option always shows "Hide content after due date"

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Jun 2, 2024

Thank you, @brian-smith-tcril. I also tested in the Quince Sandbox with Legacy Studio. First, I configured the hide after the due date, and I can see the hidden after the due date. Then, I changed the course from instructor-paced to self-paced. Unlike in the Redwood sandbox, now I can see the hidden after the course end date instead of the due date:

Screencast.from.02-06-24.10.29.02.webm

@mariajgrimaldi mariajgrimaldi added the bug Report of or fix for something that isn't working as intended label Jun 3, 2024
@mariajgrimaldi
Copy link
Member

@jmakowski1123: this was labeled as a blocker, but while discussing it in the latest BTR meeting, we wondered whether this was related only to the notice message or the functionality. Could we remove the release blocker label if the report refers only to the notice?

@crathbun428
Copy link

@mariajgrimaldi - I'm going to spend some time testing this to see if this is just a messaging issue or if the issue is deeper and report back. However, even if this is just a messaging issue, I'd say this would be a release blocker (depending the effort needed to fix it...). Stay tuned.

@crathbun428 crathbun428 removed the release blocker Blocks the upcoming release (fix needed) label Jun 4, 2024
@crathbun428
Copy link

@mariajgrimaldi - Hey Maria - Just a head's up - after chatting with Jenna, we decided to remove the release blocker label from this ticket given the comments above.

@crathbun428
Copy link

@mariajgrimaldi @jmakowski1123 @brian-smith-tcril - Confirming what Maria said - the course outline in studio only shows the "hidden after course end date" for self-paced courses. Not sure if this is a bug other than maybe the option to hide the assessment after the due date text should maybe be tweaked for self paced courses to reflect that it will only be hidden after course end date (and in that case... is this even an option that course teams need for self-paced courses)?? Might no longer be high priority to fix?

Message for instructor-paced courses
Image

Message for self-paced courses

Image

@mariajgrimaldi
Copy link
Member

@crathbun428: That's what I think! The message might be a bit confusing, but does it affect the behavior in any way? We should update the message so it's less misleading, but not as a priority fix.

@mariajgrimaldi
Copy link
Member

Hello @brian-smith-tcril, do you have an update on this issue? Let us know, thanks!

@crathbun428
Copy link

@jmakowski1123 - it looks like this bug discovered during Redwood testing only appears for self-paced courses - is it expected that for self-paced courses that the restriction would be for when the course ends? Or should this actually be hidden after some "due date"? Trying to decide if this a real bug or just a messaging issue.

See screenshots below:
Message for instructor-paced courses

Image

Message for self-paced courses

Image

@mariajgrimaldi
Copy link
Member

@pdpinch
Copy link

pdpinch commented Dec 6, 2024

I'm not sure, but I think the issue in this case is that when a course is self-paced, the instructor cannot set the due date. So a setting that "hides after due date" isn't meaningful. However, hiding after the end date for the course can make sense, if the instructor wants to obscure solutions once the course has ended.

In other words, the course end date is functionally the due date for all assignments in a self-paced course.

If this needs to be fixed, my recommendation would be to change the label for the setting when the course is self-paced: "Hide content after due date" → "Hide content after end date"

It may make sense to change the help text as well:

After the subsection's due date has passed, learners can no longer access its content. The subsection is not included in grade calculations.

After the course's end date has passed, learners can no longer access its content. The subsection is not included in grade calculations.

TC_AUTHOR_21

@crathbun428
Copy link

@pdpinch - Thank you for this - updating the labeling and adding help text makes sense as the only fixes we should make here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended release testing Affects the upcoming release (attention needed)
Projects
Status: In progress
Development

No branches or pull requests

5 participants