You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried removing that constraint and running make upgrade then make test. Sure enough, a test fails:
FAILED tests/test_check_django_deps.py::test_django_deps_upgrade[/System/Volumes/Data/root/src/edx/src/edx-repo-health/tests/fake_repos/python_repo] - packaging.version.InvalidVersion: Invalid version: 'p'
'p' is not a valid package
Digging into it, this is because tests/data/mock_django_dependencies_sheet.csv has:
I don't know what the version "p" is supposed to mean, or why packaging==21.3 was ok with it, and packaging==23.2 is not. If I manually change the version in the .csv to "master", the test fails because master is also not a valid version.
The text was updated successfully, but these errors were encountered:
requirements/constraints.txt has:
I tried removing that constraint and running
make upgrade
thenmake test
. Sure enough, a test fails:Digging into it, this is because tests/data/mock_django_dependencies_sheet.csv has:
The arrowed line has a version of "p".
It was changed in a Python Requirements Update by edx-requirements-bot:
I don't know what the version "p" is supposed to mean, or why packaging==21.3 was ok with it, and packaging==23.2 is not. If I manually change the version in the .csv to "master", the test fails because master is also not a valid version.
The text was updated successfully, but these errors were encountered: