Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't unpin packaging dependency #454

Open
nedbat opened this issue Dec 1, 2023 · 1 comment
Open

Can't unpin packaging dependency #454

nedbat opened this issue Dec 1, 2023 · 1 comment

Comments

@nedbat
Copy link
Contributor

nedbat commented Dec 1, 2023

requirements/constraints.txt has:

# greater version breaking test.
packaging==21.3

I tried removing that constraint and running make upgrade then make test. Sure enough, a test fails:

FAILED tests/test_check_django_deps.py::test_django_deps_upgrade[/System/Volumes/Data/root/src/edx/src/edx-repo-health/tests/fake_repos/python_repo] - packaging.version.InvalidVersion: Invalid version: 'p'
'p' is not a valid package

Digging into it, this is because tests/data/mock_django_dependencies_sheet.csv has:

,Django Package Name,edX Owned?,Python 3.9,Django 3.0,Django 3.1,Django 3.2,Last Checked,Ticket URL,Notes,openedxstats
37,edx-django-sites-extensions,yes,-,3.1.0,3.1.0,3.1.0,"Jul 28, 2021",BOM-2681,,
40,edx-opaque-keys,yes,-,2.2.0,2.2.0,-,"Feb 1, 2021",,,
103,django-storages,,1.11,1.8,1.1,-,"Jun 21, 2021",https://github.com/edx/upgrades/issues/44,,
110,edx-django-utils,yes,-,master,4.2.0,4.2.0,"Jul 14, 2021",BOM-2634,,
30,djangorestframework,,3.12.3,3.11.0,3.12.0,p,"Jun 30, 2021",,,3.12.4              <<<<<<<<<<
29,django-waffle,,2.2.0,0.19.0,2.0.0,-,"May 22, 2021",,,

The arrowed line has a version of "p".

It was changed in a Python Requirements Update by edx-requirements-bot:

 110,edx-django-utils,yes,-,master,4.2.0,4.2.0,"Jul 14, 2021",BOM-2634,,
-30,djangorestframework,,3.12.3,3.11.0,3.12.0,master,"Jun 30, 2021",,,3.12.4
+30,djangorestframework,,3.12.3,3.11.0,3.12.0,p,"Jun 30, 2021",,,3.12.4
 29,django-waffle,,2.2.0,0.19.0,2.0.0,-,"May 22, 2021",,,

I don't know what the version "p" is supposed to mean, or why packaging==21.3 was ok with it, and packaging==23.2 is not. If I manually change the version in the .csv to "master", the test fails because master is also not a valid version.

@iamsobanjaved
Copy link
Contributor

PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants