Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disconnected installs linter to DSPO #139

Closed
HumairAK opened this issue Jun 8, 2023 · 3 comments
Closed

Add disconnected installs linter to DSPO #139

HumairAK opened this issue Jun 8, 2023 · 3 comments
Assignees

Comments

@HumairAK
Copy link
Contributor

HumairAK commented Jun 8, 2023

RHODS-7936 introduces a linter to make disconnected installs less likely to fail for things like referencing images by tag. Add this linter to the DSPO project.

@VedantMahabaleshwarkar is a good contact for this.

@HumairAK
Copy link
Contributor Author

This will probably need to be moved downstream since we don't want to use sha images upstream.

We also don't reference images directly in deployments or kustomization.yamls, we do them via configs, so maybe a better alternative that applies to both upstream/downstream would be to ensure image fields are always parameterized in manifest deployed via dspo.

@rimolive rimolive self-assigned this Jun 14, 2023
@rimolive
Copy link
Contributor

rimolive commented Jun 15, 2023

I found some blockers to implement this check:

  • kube-linter only checks for .yaml and .yml extensions. All operators generate template files from the k8s objects, with the extension .yaml.tmpl. This is hard-coded, so there is no parameter you can use to pattern-match these files
  • The latest-tag check is a simple check that only checks for specific tags that aren't allowed. Again, I did not find a way to configure the pattern match for the forbidden tags
  • There is an implementation (still WIP) to check for sha image references, but not yet merged.

That said, it is not possible to have a good linter to check for the disconnected installs, thus it requires us for a plan B.

@rimolive rimolive changed the title Add disconnected installs linter to DSPO [BLOCKER] Add disconnected installs linter to DSPO Jun 15, 2023
@HumairAK HumairAK changed the title [BLOCKER] Add disconnected installs linter to DSPO Add disconnected installs linter to DSPO Jun 15, 2023
@rimolive
Copy link
Contributor

Proposed PR: #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants