Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken requirements.txt and Pipfile #32

Open
Informatic opened this issue May 5, 2019 · 0 comments
Open

Broken requirements.txt and Pipfile #32

Informatic opened this issue May 5, 2019 · 0 comments
Assignees

Comments

@Informatic
Copy link
Contributor

Informatic commented May 5, 2019

Seems like Pipfile is missing some dependencies defined in requirements.txt. (ex. Flask-Security - a direct project dependency, while also containing some second-level dependencies like asn1crypto)
Additionally, as requirements.txt now does >= version match, newest version of psycopg2 fails to install in Docker environment due to missing postgresql headers (psycopg2 used to default to binary build, now this is split into psycopg2-binary package, it seems) - replacing psycopg2 with psycopg2-binary in requirements.txt solves this partially in that case.

Generally speaking, we should always have some locked versions, that could then be upgraded. I haven't used Pipfile so can't really say anything about it, if Pipfile.lock really locks proper version, then we can fully migrate to Pipfile. In that case we'd have to re-add missing dependencies from requirements.txt into Pipfile and modify Dockerfile to only use Pipfile/pipenv.

@ohheyitsdave can you elaborate on that?

@ohheyitsdave ohheyitsdave self-assigned this Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants