Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set the end_date on memberships that were not part of the last import #65

Open
jpmckinney opened this issue Mar 30, 2014 · 7 comments
Labels

Comments

@jpmckinney
Copy link
Member

This functionality can be "opt-in". Curious to hear from others re: implementation.

@jpmckinney jpmckinney changed the title Automatically set the end_date on memberships that were not part of the last scrape Automatically set the end_date on memberships that were not part of the last import Mar 30, 2014
@jamesturk
Copy link
Member

this is an interesting idea for sure, i'm a bit nervous about all the weird hiccups that happen on a site marking someone as removed from office without human intervention

brainstorming on how it'd work I think there'd be a "scrapes_everyone_currently_in_office_i_promise" flag on the scraper that the importer would find out about somehow, if that was set it'd trigger a function that disabled everyone that wasn't in that scrape

@jpmckinney
Copy link
Member Author

That would work for me.

Is there anything like Merge-o-Matic planned for Pupa?

@jpmckinney
Copy link
Member Author

This is still an important need for Represent. Wondering what current thinking is. /cc @paultag

@paultag
Copy link
Contributor

paultag commented Oct 15, 2014

Hurm, yeah, interesting.

Too bad we don't have billy-like terms for the Legislator scraping, that would let us flip the date if we're at a session break (which I think Billy did)

I think @jamesturk 's idea is likely spot on, I am a bit sketchy on this as default, since we do have site hiccups that end up dropping people, and I'd hate for them to get set to retired / historical.

A flag isn't unreasonable

@fgregg
Copy link
Contributor

fgregg commented Sep 22, 2015

I think this should not be done. I do think there should be a pretty lightweight way to declare terms particularly for former members. Maybe a YAML file.

@jpmckinney
Copy link
Member Author

@fgregg It can be opt-in.

@jamesturk
Copy link
Member

I think an opt-in setting on the scraper is the way to go.

I admittedly don't have a near term need for this but very open to patches in the interim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants