-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically set the end_date on memberships that were not part of the last import #65
Comments
this is an interesting idea for sure, i'm a bit nervous about all the weird hiccups that happen on a site marking someone as removed from office without human intervention brainstorming on how it'd work I think there'd be a "scrapes_everyone_currently_in_office_i_promise" flag on the scraper that the importer would find out about somehow, if that was set it'd trigger a function that disabled everyone that wasn't in that scrape |
That would work for me. Is there anything like Merge-o-Matic planned for Pupa? |
This is still an important need for Represent. Wondering what current thinking is. /cc @paultag |
Hurm, yeah, interesting. Too bad we don't have billy-like terms for the Legislator scraping, that would let us flip the date if we're at a session break (which I think Billy did) I think @jamesturk 's idea is likely spot on, I am a bit sketchy on this as default, since we do have site hiccups that end up dropping people, and I'd hate for them to get set to retired / historical. A flag isn't unreasonable |
I think this should not be done. I do think there should be a pretty lightweight way to declare terms particularly for former members. Maybe a YAML file. |
@fgregg It can be opt-in. |
I think an opt-in setting on the scraper is the way to go. I admittedly don't have a near term need for this but very open to patches in the interim. |
This functionality can be "opt-in". Curious to hear from others re: implementation.
The text was updated successfully, but these errors were encountered: