Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression detection against case breakage #54

Open
gluap opened this issue Feb 26, 2022 · 0 comments
Open

Regression detection against case breakage #54

gluap opened this issue Feb 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@gluap
Copy link
Contributor

gluap commented Feb 26, 2022

In #52 @codingcatgirl suggested to add a regression detection to the build:

By calculating the intersection of the PCB with the case one could validate that no accidental overlap happens.

Openscad can raise an error when it sees an empty geometry as a result of an intersection, which we could use as an indicator that everything is alright. However it was also mentioned that this is not 100% reliable with complex geometries

@gluap gluap added the enhancement New feature or request label Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant