Error during validation of event type length

[AndrewKvalheim]

I'm submitting a…

• Bug Report
• Feature Request

Current behavior

When editing an event type, it’s possible to blank the length field:

This triggers a server error during validation:

Started PATCH "/admin/conferences/example/program/event_types/1"
Processing by Admin::EventTypesController#update as HTML
  Parameters: {"authenticity_token"=>"[FILTERED]", "event_type"=>{"title"=>"Talk", "length"=>"", "description"=>"Presentation in lecture format", "minimum_abstract_length"=>"0", "maximum_abstract_length"=>"500", "color"=>"#ff0000"}, "commit"=>"Update Event type", "conference_id"=>"example", "id"=>"1"}
Completed 500 Internal Server Error

NoMethodError (undefined method `%' for nil:NilClass

    errors.add(:length, "must be a divisor of #{program.schedule_interval}") if program && length % program.schedule_interval != 0
                                                                                                  ^):

app/models/event_type.rb:27:in `length_step'
app/controllers/admin/event_types_controller.rb:29:in `update'

Expected correct behavior

Either a validation error (not a server error) is returned or a default value is used.

Steps to reproduce

1. Create a conference.
2. At Manage → Event Types → Edit, blank the Length field and click Update Event type.

Other information

I briefly researched whether the length_step validation could be made dependent on the numericality validation, but didn’t find a straightforward solution.

[makrianast]

i would like to work on that

[hennevogel]

@makrianast what's stopping you to submit a pull request?