Missing templates for admin forms #2975

AndrewKvalheim · 2022-03-21T23:22:37Z

I'm submitting a ..

Bug Report
Feature Request

Current behavior:

Some pages in the admin interface are broken with ActionController::MissingExactTemplate:

Administration → Users → Edit (Admin::UsersController#edit)
Manage conference → Events → Add Event (Admin::EventsController#new)

Expected correct behavior:

Show the appropriate form.

Steps to reproduce:

In a new instance, create a conference and navigate as above.

Other information:

Completing #2921 should help with this.

The text was updated successfully, but these errors were encountered:

hennevogel · 2022-03-29T14:10:14Z

It's probably fallout of removing the general new/edit/form templates from app/views/layouts

hennevogel · 2022-03-29T14:10:34Z

Also point to some missing specs for this functionality

ghost · 2022-04-16T11:44:21Z

@hennevogel I'd love to work on this ^^ Seems like a good first issue to get started 😉

hennevogel · 2022-04-19T10:43:35Z

@Liberatys knock yourself out 😃

YTeyddie22 · 2022-05-18T03:36:20Z

Is this issue still open?

hennevogel · 2022-05-24T12:48:33Z

@YTeyddie22 sure is

mkiroshdz · 2022-05-26T14:04:35Z

@hennevogel I'm working on putting the views back but I'm not sure what fields the user form needs to have. Can you please provide me those?. Thanks

hennevogel · 2022-06-22T13:45:32Z

@mkiroshdz sorry for the late answer, this one slipped through the cracks 😞

I would say:

name
email_public
biography
nickname
affiliation
avatar
languages
is_admin
is_disabled

Fails with: 1) User admin behaves like admin ability edits a user Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::UsersController#edit is missing a template for request formats: text/html re openSUSE#2975

Fails with: 1) Event as an conference organizer create a proposal Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::EventsController#new is missing a template for request formats: text/html re openSUSE#2975

AndrewKvalheim · 2022-09-12T23:44:56Z

For reference here’s the former template resolution:

Started GET "/admin/users/1/edit"
Processing by Admin::UsersController#edit as HTML
  Rendering layouts/application.html.haml
  Rendering application/edit.html.haml within layouts/application
  Rendered admin/users/_form.html.haml

Started GET "/admin/conferences/example/program/events/new"  
Processing by Admin::EventsController#new as HTML  
  Rendering layouts/application.html.haml
  Rendering application/new.html.haml within layouts/application
  Rendered proposals/_proposal_form.html.haml
  Rendered admin/events/_form.html.haml

#!/usr/bin/env bash set -Eeuxo pipefail function merge() { id="$1"; title="$2" git pull --no-ff --no-commit --strategy-option 'theirs' 'openSUSE' "pull/$id/head" git commit --message "Merge #$id \"$title\"" items+=( "- [ ] $title [#$id](https://github.com/openSUSE/osem/pull/$id)" ) } function pick() { hash="$1"; title="$2" git cherry-pick "$hash" rebased="$(git rev-parse HEAD)" items+=( "- [ ] $title [\`${rebased:0:7}\`]($rebased)" ) } function revert() { hash="$1"; title="$2"; note="$3" git revert --no-edit "$hash" items+=( "- [ ] Revert “$title” [\`${hash:0:7}\`](openSUSE@$hash) ($note)" ) } items=() git fetch --all --prune git checkout 'main' git reset --hard 'openSUSE/master' merge '2654' 'Fix access to the version history of organization-level roles' pick '5997a3194383e63088a400896dcb7c78f5b562c7' 'Restore now-passing tests' merge '3058' 'Add surveys during CFP response' merge '3059' 'Add setting to disable email notifications of comments' pick '3b4da2f6930bcd09a5cdecd5b0efc57ed80b6c87' 'Configure for deployment to Dokku' pick '7afa84bb1e4d34e5d0eda2176f1519fff1588307' 'Restore lost admin forms [openSUSE#2975](openSUSE#2975)' IFS=$'\n' cat << MARKDOWN > 'README.md' # About this branch Our goal is to run [upstream] OSEM without modifications to its codebase. We currently still make a few modifications in this transitional branch: ${items[*]} These divergences from upstream should be seen as a to-do list, where completing an item means either solving its need in a general way upstream, or adjusting our procedures to accommodate upstream’s existing capabilities or limitations. ## Guidelines Don’t develop on this branch. It follows upstream by regularly **rebasing** the above modifications. When a modification is no longer necessary, it will be dropped during the rebase. When there are no remaining modifications, this branch will be deleted. [upstream]: https://github.com/openSUSE/osem MARKDOWN git add 'README.md' git commit --message "Document branch $(cat "${BASH_SOURCE[0]}")" git --no-pager log --color --oneline 'openSUSE/master'..'main'

Amjt11 · 2022-10-08T08:52:46Z

Lol

ams0 · 2023-02-17T20:36:40Z

I'd love to use this for Kubernetes Community Days Amsterdam 2023 but currently hitting this bug too, I cannot add events to manually create the conference schedule. I deployed it on a VM using docker compose instructions.

If you know of any workaround, I'm all ears!

AndrewKvalheim · 2023-02-17T22:35:53Z

While they’re not yet reviewed there are a few attempted solutions you could pull from in a pinch:

Bugfix/restore users events edit views #3073, which introduces undiscussed changes and has no tests
Add admin form for new event #3092, which introduces undiscussed changes and has no tests
Restore views for Admin::EventsController#new, Admin::UsersController#edit #3129, which tests and restores the forms with no other changes

Fails with: 1) User admin behaves like admin ability edits a user Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::UsersController#edit is missing a template for request formats: text/html re openSUSE#2975

Fails with: 1) Event as an conference organizer create a proposal Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::EventsController#new is missing a template for request formats: text/html re openSUSE#2975

In openSUSE#2987 the detailed view of the event form was inadvertently lost, presumably due to openSUSE#2975 masking the problem.

Fails with: 1) User admin behaves like admin ability edits a user Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::UsersController#edit is missing a template for request formats: text/html re openSUSE#2975

Fails with: 1) Event as an conference organizer create a proposal Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::EventsController#new is missing a template for request formats: text/html re openSUSE#2975

…ler#edit 1. Restore views lost during 81853d1: git restore --source 4a16836 \ app/views/admin/users/_form.html.haml \ app/views/application/edit.html.haml \ app/views/application/new.html.haml mv app/views/application/edit.html.haml app/views/admin/users/ mv app/views/application/new.html.haml app/views/admin/events/ 2. Convert from Formtastic: - app/views/admin/users/_form.html.haml 3. Add headers as in 81853d1: - app/views/admin/events/new.html.haml - app/views/admin/users/edit.html.haml 4. Substitute partial unified in 88b5596: - app/views/admin/events/new.html.haml resolves openSUSE#2975

In openSUSE#2987 the detailed view of the event form was inadvertently lost, presumably due to openSUSE#2975 masking the problem.

Fails with: 1) User admin behaves like admin ability edits a user Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::UsersController#edit is missing a template for request formats: text/html re openSUSE#2975

Fails with: 1) Event as an conference organizer create a proposal Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::EventsController#new is missing a template for request formats: text/html re openSUSE#2975

…ler#edit 1. Restore views lost during 81853d1: git restore --source 4a16836 \ app/views/admin/users/_form.html.haml \ app/views/application/edit.html.haml \ app/views/application/new.html.haml mv app/views/application/edit.html.haml app/views/admin/users/ mv app/views/application/new.html.haml app/views/admin/events/ 2. Convert from Formtastic: - app/views/admin/users/_form.html.haml 3. Add headers as in 81853d1: - app/views/admin/events/new.html.haml - app/views/admin/users/edit.html.haml 4. Substitute partial unified in 88b5596: - app/views/admin/events/new.html.haml resolves openSUSE#2975

…ler#edit 1. Restore views lost during 81853d1: git restore --source 4a16836 \ app/views/admin/users/_form.html.haml \ app/views/application/edit.html.haml \ app/views/application/new.html.haml mv app/views/application/edit.html.haml app/views/admin/users/ mv app/views/application/new.html.haml app/views/admin/events/ 2. Convert from Formtastic: - app/views/admin/users/_form.html.haml 3. Add header as in 81853d1: - app/views/admin/events/new.html.haml 4. Substitute partial unified in 88b5596: - app/views/admin/events/new.html.haml resolves openSUSE#2975

In openSUSE#2987 the detailed view of the event form was inadvertently lost, presumably due to openSUSE#2975 masking the problem.

Fails with: 1) User admin behaves like admin ability edits a user Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::UsersController#edit is missing a template for request formats: text/html re openSUSE#2975

Fails with: 1) Event as an conference organizer create a proposal Failure/Error: raise ActionController::MissingExactTemplate, message ActionController::MissingExactTemplate: Admin::EventsController#new is missing a template for request formats: text/html re openSUSE#2975

hennevogel added good first issue For RoR beginners or people unfamiliar with the application bug 🐛 Something is wrong and needs to be fixed labels Mar 29, 2022

mkiroshdz mentioned this issue Jul 20, 2022

Bugfix/restore users events edit views #3073

Open

5 tasks

AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this issue Mar 1, 2023

Restore detailed event form for admins

0c2ccf4

In openSUSE#2987 the detailed view of the event form was inadvertently lost, presumably due to openSUSE#2975 masking the problem.

AndrewKvalheim mentioned this issue Mar 1, 2023

Restore views for Admin::EventsController#new, Admin::UsersController#edit #3129

Merged

5 tasks

AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this issue Mar 1, 2023

Restore detailed event form for admins

066adde

In openSUSE#2987 the detailed view of the event form was inadvertently lost, presumably due to openSUSE#2975 masking the problem.

AndrewKvalheim added a commit to AndrewKvalheim/osem that referenced this issue May 2, 2023

Restore detailed event form for admins

c403247

In openSUSE#2987 the detailed view of the event form was inadvertently lost, presumably due to openSUSE#2975 masking the problem.

hennevogel closed this as completed in 3ae1275 May 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Missing templates for admin forms #2975

Missing templates for admin forms #2975

AndrewKvalheim commented Mar 21, 2022

hennevogel commented Mar 29, 2022

hennevogel commented Mar 29, 2022 •

edited

Loading

ghost commented Apr 16, 2022

hennevogel commented Apr 19, 2022

YTeyddie22 commented May 18, 2022

hennevogel commented May 24, 2022

mkiroshdz commented May 26, 2022

hennevogel commented Jun 22, 2022

AndrewKvalheim commented Sep 12, 2022 •

edited

Loading

Amjt11 commented Oct 8, 2022

ams0 commented Feb 17, 2023 •

edited

Loading

AndrewKvalheim commented Feb 17, 2023 •

edited

Loading

Missing templates for admin forms #2975

Missing templates for admin forms #2975

Comments

AndrewKvalheim commented Mar 21, 2022

hennevogel commented Mar 29, 2022

hennevogel commented Mar 29, 2022 • edited Loading

ghost commented Apr 16, 2022

hennevogel commented Apr 19, 2022

YTeyddie22 commented May 18, 2022

hennevogel commented May 24, 2022

mkiroshdz commented May 26, 2022

hennevogel commented Jun 22, 2022

AndrewKvalheim commented Sep 12, 2022 • edited Loading

Amjt11 commented Oct 8, 2022

ams0 commented Feb 17, 2023 • edited Loading

AndrewKvalheim commented Feb 17, 2023 • edited Loading

hennevogel commented Mar 29, 2022 •

edited

Loading

AndrewKvalheim commented Sep 12, 2022 •

edited

Loading

ams0 commented Feb 17, 2023 •

edited

Loading

AndrewKvalheim commented Feb 17, 2023 •

edited

Loading