Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collecting additional information during submissions #2528

Closed
4 tasks
rishabhptr opened this issue Jun 3, 2019 · 8 comments
Closed
4 tasks

Collecting additional information during submissions #2528

rishabhptr opened this issue Jun 3, 2019 · 8 comments
Labels
need feedback ❓ Do not start working on it until a decision is reached

Comments

@rishabhptr
Copy link
Contributor

rishabhptr commented Jun 3, 2019

As a part of the GSoC project. We want to collect additional details such a contact, social media, additional requests for.

  • Add social media links
  • Add contact fields
  • Add a field for entering additional requirements.
  • Change the respective form and views.

For the Social media links, I have proposed to use the contact model which already exists for the social media links and create a polymorphic association with the track and booth models.
One query regarding this is should I leave the existing association with conference model as it is or change that too?

For contact fields I think we should add a website_url for tracks just like booths. Other options such as email / social _tag are covered in contact model.

@Ana06
Copy link
Member

Ana06 commented Jun 6, 2019

Where do you want to add this information? I guess you speak about the submission the tracks and booths, right?

For the Social media links, I have proposed to use the contact model which already exists for the social media links and create a polymorphic association with the track and booth models.

This sounds good to me.

One query regarding this is should I leave the existing association with conference model as it is or change that too?

What do you exactly mean?

For contact fields I think we should add a website_url for tracks just like booths

👍

@rishabhptr
Copy link
Contributor Author

Where do you want to add this information? I guess you speak about the submission the tracks and booths, right?

Yeah, this is related to Tracks/Booths.

One query regarding this is should I leave the existing association with conference model as it is or change that too?

What I mean to say is that using polymorphic association we would have contactable_type and contactable_id field for contact, so is it good practice to convert the has_one association between conference and contact to polymorphic association too.

@Ana06
Copy link
Member

Ana06 commented Jun 13, 2019

@rishabhptr what about you send a PR with a suggestion? It is much easier to discuss about code when seeing the code and we want to see the work you are doing 😉

@Ana06 Ana06 added the need feedback ❓ Do not start working on it until a decision is reached label Jun 13, 2019
@rishabhptr
Copy link
Contributor Author

rishabhptr commented Jun 13, 2019

@rishabhptr what about you send a PR with a suggestion? It is much easier to discuss about code when seeing the code and we want to see the work you are doing wink

@Ana06 Yes, you're right and sorry for not updating earlier. I have created a PR explaining my approach and the concerns that I am facing. Thanks!

@differentreality
Copy link
Contributor

I am wondering if we want to allow people to submit custom things, in addition to the predefined fields, so that they can determine both the description as well as submit the equivalent value (eg. a link to project's repo).
Then the table can look like this:

ID | description | text
1 | Project license | X license
2 | Project repo | link-to-repo

@rishabhptr
Copy link
Contributor Author

It's a nice idea and I don't think it would affect the contact/social-media field and the other fields that I have mentioned in the PR.

If this is a requirement we can definitely work on it and the discuss the approach here. I am assuming that we would need a different table to implement this.

@AndrewKvalheim
Copy link
Member

Addressing a similar need: #3058

@hennevogel
Copy link
Member

GSoC is long over :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need feedback ❓ Do not start working on it until a decision is reached
Projects
None yet
Development

No branches or pull requests

5 participants