Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug : profile photo not visible after changing theme , need to refresh #2486

Open
NiranjanNlc opened this issue Jan 17, 2024 · 13 comments
Open
Assignees
Labels

Comments

@NiranjanNlc
Copy link
Contributor

Summary:

While we change the theme of the app , the profile photo is not visible in home page

Steps to reproduce:

  1. Open the app
  2. change the theme of the app .
  3. observe the profile photo in home page

Expected behaviour:

Profile photo should be clearly visible despite changing profile photo

Observed behaviour:

when we normally open the app, the profile photo is normally visible . But , when we change the app theme , the profile photo seems go nowhere. The space of the profile photo is observed empty and the profile photo is invisible .
Device and Android version:

Redm 9A , android version : 10

Screenshots:

Screenrecorder-2024-01-17-08-19-34-467.mp4
@NiranjanNlc
Copy link
Contributor Author

i will be working on this .

@PratyushSingh07 , please get me this issuses assigned

@PratyushSingh07
Copy link
Collaborator

But the profile picture re appears when you pull down to refresh

@NiranjanNlc
Copy link
Contributor Author

yeah i noticed but was not it supposed to appear without refereshng

@NiranjanNlc NiranjanNlc changed the title Bug : profile photo not visble after changing theme Bug : profile photo not visible after changing theme , need to refresh Jan 17, 2024
@PratyushSingh07
Copy link
Collaborator

yeah i noticed but was not it supposed to appear without refereshng

not really sure, you can solve it and then maybe we can ask rajan to have a look at it

@arjesh-vadadoria
Copy link

Hello @NiranjanNlc @PratyushSingh07 , If anyone is not working on it, can I try to solve this?

@arjesh-vadadoria
Copy link

@PratyushSingh07 if this is not fixed, then can I work on this?

@NiranjanNlc
Copy link
Contributor Author

I am working on this @arjesh-vadadoria .

@arjesh-vadadoria
Copy link

Okay no problem @NiranjanNlc ,
@PratyushSingh07 if we have any other issues, can you please assign it to me, I can work with intermediate to advanced issues too.

@NiranjanNlc
Copy link
Contributor Author

It was a completely simple fix .
Would you review from your end @PratyushSingh07

@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Feb 13, 2024

Does this issue persist following the latest commit @NiranjanNlc @AvneetSingh2001 ? If not then we can close this issue and the PR linked to this

@AvneetSingh2001
Copy link
Collaborator

AvneetSingh2001 commented Feb 13, 2024

I have migrated the HomeFragment to compose and handled this issue already in that PR, which is merged also.
But for navigation drawer, the issue is still there. @PratyushSingh07
One way is @NiranjanNlc can only include the changes of Navigation drawer in the PR, or we can raise another PR to migrate drawer also to Compose.

@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Feb 13, 2024

Thank you @AvneetSingh2001 . @NiranjanNlc the choice is yours. You can either migrate the nav drawer to compose or you can amend your existing PR to only include the changes in nav drawer.
If you ask me then migrating the nav drawer to compose will be a more viable option

@NiranjanNlc
Copy link
Contributor Author

@PratyushSingh07 , ammended the PR for now .
Needed some more effort, time and learning to migrate nav drawer .
please get my PR reviewed for now .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants