Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [#108] Show if Abonnement callback URL can be reached in admin #186

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

✨ [#108] Show if Abonnement callback URL can be reached in admin #186

wants to merge 3 commits into from

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Aug 30, 2024 •
edited
Loading

fixes #108

Coperh
Coperh approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works for me

annashamray
annashamray reviewed Sep 2, 2024
View reviewed changes
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, but I'm afraid that if there are a lot of subscribers the admin page would be loading for a while
Perhaps we should only show it in the detail view?
What do you think?

@stevenbal
Copy link
Contributor Author

@annashamray hmm that's right, though if it's on the detail view, it isn't really convenient if you want to check multiple subscriptions, because you'd have to open every detail page. Maybe there should be a button/action to trigger it?

Also come to think of it, I'm not sure if the Abonnementen page is the right place for this, shouldn't it be the Webhook subscriptions?

@stevenbal stevenbal marked this pull request as draft October 3, 2024 09:16
@stevenbal stevenbal force-pushed the feature/108-abonnement-admin-callback-url-reachable branch from 7f4e311 to 401b44b Compare October 4, 2024 08:57
@stevenbal stevenbal force-pushed the feature/108-abonnement-admin-callback-url-reachable branch from 401b44b to 2238c16 Compare October 4, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray annashamray left review comments

@Coperh Coperh Coperh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abonnementen admin: show if the callback URL can be reached
3 participants
@stevenbal @Coperh @annashamray