Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to TypeScript 5.5 #267

Open
maxpatiiuk opened this issue Jul 22, 2024 · 2 comments · May be fixed by #268
Open

Update to TypeScript 5.5 #267

maxpatiiuk opened this issue Jul 22, 2024 · 2 comments · May be fixed by #268

Comments

@maxpatiiuk
Copy link

Could you please update custom-elements-manifest/analyzer to TypeScript 5.5?
TypeScript 5.5 brings a lot exciting improvements, and it would be nice to be able to use it with custom-elements-manifest/analyzer
@thepassle
Copy link
Member

Yeah I'd be happy to take a PR to update it 🙂

@maxpatiiuk
Copy link
Author

Opened a PR - #268

Out of curiosity, I have a question for you:
Given that the project relies so closely on the TypeScript compiler, why is the project itself not written in TypeScript?

That would make maintenance effort like updating dependency version easier since TypeScript will catch places in code that need to be updated in response to dependency update.

The lack of typing definitions for this project is decremental for the community.
Comments like this are common

Larger projects like https://github.com/break-stuff/cem-tools/ shipped their own typings for CEM, but those typings sometimes are not matching reality, causing issues

@maxpatiiuk maxpatiiuk linked a pull request Jul 23, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update TypeScript to v5.5.4 maxpatiiuk/custom-elements-manifest
2 participants
@thepassle @maxpatiiuk